Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-dev doesn't support building with external llvm #76572

Closed
semarie opened this issue Sep 10, 2020 · 1 comment · Fixed by #76573
Closed

rust-dev doesn't support building with external llvm #76572

semarie opened this issue Sep 10, 2020 · 1 comment · Fixed by #76573
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@semarie
Copy link
Contributor

semarie commented Sep 10, 2020

When building rustc-nightly (e2be5f5 here), the build error inside RustDev Target with:

> RustDev { target: TargetSelection { triple: "x86_64-unknown-openbsd", file: None } }
Dist RustDev (x86_64-unknown-openbsd)
thread 'main' panicked at 'Error: File "/data/semarie/build-rust/build_dir/build/x86_64-unknown-openbsd/llvm/bin/llvm-config" not found!', src/bootstrap/lib.rs:1273:17
stack backtrace:
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
        finished in 0.205

The build is done with the following config.toml:

[build]
rustc = "/data/semarie/build-rust/install_dir/beta/bin/rustc"
cargo = "/data/semarie/build-rust/install_dir/beta/bin/cargo"
rustfmt = "/data/semarie/build-rust/install_dir/beta/bin/rustfmt"
python = "/usr/local/bin/python3"
gdb = "/usr/local/bin/egdb"
#docs = false
vendor = true
extended = true
verbose = 1

[install]
prefix = "/data/semarie/build-rust/install_dir/nightly"

[dist]
src-tarball = false

[rust]
channel = "nightly"
codegen-tests = false
verbose-tests = true

[target.x86_64-unknown-openbsd]
llvm-config = "/usr/local/bin/llvm-config"

[llvm]
static-libstdcpp = false
ninja = true

Please note that llvm is system wide installed.

I am a bit unsure about the exact purpose of RustDev. but it seems to me that it should be not build if llvm is external ?

Cc: @Mark-Simulacrum

@semarie semarie added the C-bug Category: This is a bug. label Sep 10, 2020
@Mark-Simulacrum
Copy link
Member

Yes, I had hoped it would just work but I guess not. I will post a PR fixing it shortly. It is indeed not really intended for building with external LLVM.

@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 10, 2020
@bors bors closed this as completed in d778203 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants