Lint path statements to suggest using drop when the type needs drop #75056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ Thanks! that was quite a long-standing issue |
|
📌 Commit 4eab8bce82cddfccc9a7392bec180b205110b79a has been approved by |
bors
added
S-waiting-on-bors
|
Just for completeness, should this also include a test for types that have drop glue but don't impl Drop themselves? An example being a single-element tuple that contains a Drop type. |
|
@bors r- That's a good idea |
bors
added
S-waiting-on-author
Veykril
force-pushed
the
path_statements_lint
branch
from
4eab8bc to
35d6a2e
Compare
|
Added the extra test case |
|
@bors r+ |
|
📌 Commit 35d6a2e has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…-obk Lint path statements to suggest using drop when the type needs drop Fixes rust-lang#48852. With this change the current lint description doesn't really fit entirely anymore I think.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…-obk Lint path statements to suggest using drop when the type needs drop Fixes rust-lang#48852. With this change the current lint description doesn't really fit entirely anymore I think.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 3, 2020
…-obk Lint path statements to suggest using drop when the type needs drop Fixes rust-lang#48852. With this change the current lint description doesn't really fit entirely anymore I think.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2020
…-obk Lint path statements to suggest using drop when the type needs drop Fixes rust-lang#48852. With this change the current lint description doesn't really fit entirely anymore I think.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74759 (add `unsigned_abs` to signed integers) - rust-lang#75043 (rustc_ast: `(Nested)MetaItem::check_name` -> `has_name`) - rust-lang#75056 (Lint path statements to suggest using drop when the type needs drop) - rust-lang#75081 (Fix logging for rustdoc) - rust-lang#75083 (Do not trigger `unused_braces` for `while let`) - rust-lang#75084 (Stabilize Ident::new_raw) - rust-lang#75103 (Disable building rust-analyzer on riscv64) - rust-lang#75106 (Enable docs on in the x86_64-unknown-linux-musl manifest) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48852. With this change the current lint description doesn't really fit entirely anymore I think.