rustc_ast: (Nested)MetaItem::check_name -> has_name
#75043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Why do we not have to track usage for Also, #74932 will still be relevant after this lands, right? It will just be smaller and simpler. r=me once the extra comment or two has been added. Thanks for doing this. |
nnethercote
reviewed
Aug 3, 2020
petrochenkov
added
S-waiting-on-author
For consistency with `Attribute::has_name` which doesn't mark the attribute as used either. Replace all uses of `check_name` with `has_name` outside of rustc
|
@bors r=nnethercote |
|
📌 Commit 05f414b has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 3, 2020
rustc_ast: `(Nested)MetaItem::check_name` -> `has_name` For consistency with `Attribute::has_name` which doesn't mark the attribute as used either. Replace all uses of `check_name` with `has_name` outside of rustc, only rustc needs to mark attributes as used. cc rust-lang#74932 r? @nnethercote
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74759 (add `unsigned_abs` to signed integers) - rust-lang#75043 (rustc_ast: `(Nested)MetaItem::check_name` -> `has_name`) - rust-lang#75056 (Lint path statements to suggest using drop when the type needs drop) - rust-lang#75081 (Fix logging for rustdoc) - rust-lang#75083 (Do not trigger `unused_braces` for `while let`) - rust-lang#75084 (Stabilize Ident::new_raw) - rust-lang#75103 (Disable building rust-analyzer on riscv64) - rust-lang#75106 (Enable docs on in the x86_64-unknown-linux-musl manifest) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency with
Attribute::has_namewhich doesn't mark the attribute as used either.Replace all uses of
check_namewithhas_nameoutside of rustc, only rustc needs to mark attributes as used.cc #74932
r? @nnethercote