Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to the rustc guide #69317

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

LeSeulArtichaut
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 20, 2020
@LeSeulArtichaut
Copy link
Contributor Author

r? @mark-i-m

@rust-highfive rust-highfive assigned mark-i-m and unassigned varkor Feb 20, 2020
@mark-i-m
Copy link
Member

Thanks! I would actually point to https://rust-lang.github.io/rustc-guide/borrow_check.html instead. "Region checking" is just jargon for "borrow checking", which is the subject of the whole chapter.

Also, I don't have r+ privileges. r? @JohnTitor or @spastorino

@rust-highfive rust-highfive assigned JohnTitor and unassigned mark-i-m Feb 20, 2020
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@Dylan-DPC-zz
Copy link

Ouch sorry xD

@LeSeulArtichaut
Copy link
Contributor Author

Edited the link

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 20, 2020

📌 Commit 8e793ed has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2020
@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-20T16:34:59.0315119Z ========================== Starting Command Output ===========================
2020-02-20T16:34:59.0318474Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/c20d847c-2984-47b0-8b54-e0041327808d.sh
2020-02-20T16:34:59.0318819Z 
2020-02-20T16:34:59.0321993Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-20T16:34:59.0338400Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69317/merge to s
2020-02-20T16:34:59.0341464Z Task         : Get sources
2020-02-20T16:34:59.0341681Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-20T16:34:59.0341943Z Version      : 1.0.0
2020-02-20T16:34:59.0342087Z Author       : Microsoft
---
2020-02-20T16:35:00.0355217Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-20T16:35:00.0361013Z ##[command]git config gc.auto 0
2020-02-20T16:35:00.0365224Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-20T16:35:00.0368710Z ##[command]git config --get-all http.proxy
2020-02-20T16:35:00.0376422Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69317/merge:refs/remotes/pull/69317/merge
---
2020-02-20T16:38:29.4154180Z E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2020-02-20T16:38:29.4188865Z 
2020-02-20T16:38:29.4252738Z ##[error]Bash exited with code '100'.
2020-02-20T16:38:29.4263694Z ##[section]Finishing: Install awscli
2020-02-20T16:38:29.4317325Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69317/merge to s
2020-02-20T16:38:29.4321735Z Task         : Get sources
2020-02-20T16:38:29.4322027Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-20T16:38:29.4322292Z Version      : 1.0.0
2020-02-20T16:38:29.4322465Z Author       : Microsoft
2020-02-20T16:38:29.4322465Z Author       : Microsoft
2020-02-20T16:38:29.4322745Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-20T16:38:29.4323085Z ==============================================================================
2020-02-20T16:38:29.7424985Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-20T16:38:29.7463759Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69317/merge to s
2020-02-20T16:38:29.7546364Z Cleaning up task key
2020-02-20T16:38:29.7547738Z Start cleaning up orphan processes.
2020-02-20T16:38:29.7727306Z Terminate orphan process: pid (3842) (python)
2020-02-20T16:38:29.7837783Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

@bors retry

@Dylan-DPC-zz
Copy link

@bors try

@bors
Copy link
Contributor

bors commented Feb 20, 2020

🙅 Please do not try after a pull request has been r+ed. If you need to try, unapprove (r-) it first.

bors added a commit that referenced this pull request Feb 20, 2020
Rollup of 5 pull requests

Successful merges:

 - #68877 (On mismatched argument count point at arguments)
 - #69185 (Unify and improve const-prop lints)
 - #69305 (Tweak binding lifetime suggestion text)
 - #69311 (Clean up E0321 and E0322)
 - #69317 (Fix broken link to the rustc guide)

Failed merges:

r? @ghost
@bors bors merged commit c1165ce into rust-lang:master Feb 20, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the patch-1 branch February 21, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants