Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On mismatched argument count point at arguments #68877

Merged
merged 1 commit into from
Feb 20, 2020
Merged

On mismatched argument count point at arguments #68877

merged 1 commit into from
Feb 20, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Feb 6, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2020
petrochenkov
petrochenkov reviewed Feb 6, 2020
View reviewed changes
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2020
@bors
Copy link
Contributor

bors commented Feb 7, 2020

☔ The latest upstream changes (presumably #68907) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2020
petrochenkov
petrochenkov reviewed Feb 9, 2020
View reviewed changes
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2020
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2020
@petrochenkov
Copy link
Contributor

r=me after squashing the commits

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2020
@estebank
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Feb 11, 2020

📌 Commit 683ebc2 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#68877 - estebank:point-at-params, r=petroch…
c33d531 
…enkov

On mismatched argument count point at arguments
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 12, 2020
Closed
@JohnTitor
Copy link
Member

Seems failed in #69085 (comment)
@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2020
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2020
@estebank
Copy link
Contributor Author

Blocked on rust-lang/cargo#7883

@estebank estebank added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2020
@estebank
Copy link
Contributor Author

After #69265, @bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Feb 20, 2020

📌 Commit 683ebc2 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 20, 2020
@bors
Copy link
Contributor

bors commented Feb 20, 2020

⌛ Testing commit 683ebc2 with merge 1a501dff214c1c084dbb2eb6bae8d9f159581a17...

@Centril
Copy link
Contributor

Centril commented Feb 20, 2020

@bors retry yielding to higher prio PR.

@bors
Copy link
Contributor

bors commented Feb 20, 2020

⌛ Testing commit 683ebc2 with merge 83e4e89b52d6c68719bf2a41a75839637c04819f...

@Centril Centril mentioned this pull request Feb 20, 2020
Merged
@Centril
Copy link
Contributor

Centril commented Feb 20, 2020

@bors retry

bors added a commit that referenced this pull request Feb 20, 2020
@bors
Auto merge of #69325 - Centril:rollup-vce2ko2, r=Centril
2c462a2 
Rollup of 5 pull requests

Successful merges:

 - #68877 (On mismatched argument count point at arguments)
 - #69185 (Unify and improve const-prop lints)
 - #69305 (Tweak binding lifetime suggestion text)
 - #69311 (Clean up E0321 and E0322)
 - #69317 (Fix broken link to the rustc guide)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Feb 20, 2020

⌛ Testing commit 683ebc2 with merge 2c462a2...

@bors bors merged commit b680a5e into rust-lang:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rust-highfive @bors @petrochenkov @JohnTitor @Centril