Rework raw ident suggestions #66592
Rework raw ident suggestions #66592
Conversation
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
raw-raw-ah-ah-ah
branch
from
3ef2b96 to
17ff1a7
Compare
This comment has been minimized.
This comment has been minimized.
| TokenKind::Comma, | ||
| TokenKind::Semi, | ||
| TokenKind::ModSep, | ||
| TokenKind::OpenDelim(token::DelimToken::Brace), |
There was a problem hiding this comment.
I think this should also include Bracket-- e.g.:
macro_rules! async { () => {} }There was a problem hiding this comment.
(but it is a heuristic, and as such it may be better not to suggest changing async { ... })
|
r=me with travis fixed |
| TokenKind::OpenDelim(token::DelimToken::Paren), | ||
| TokenKind::CloseDelim(token::DelimToken::Brace), | ||
| TokenKind::CloseDelim(token::DelimToken::Paren), | ||
| ]; |
There was a problem hiding this comment.
Code like this is pure technical debt, and my preferred solution would be to remove the diagnostic (#66126 (comment)), especially given that raw identifiers are a compatibility feature that should never be recommended in general.
There was a problem hiding this comment.
I think that with this new restriction we'll only be presenting this suggestion in the very rare cases where the intent was there.
Use heuristics to determine whethersuggesting raw identifiers is appropriate. Account for raw identifiers when printing a path in a `use` suggestion.
estebank
force-pushed
the
raw-raw-ah-ah-ah
branch
from
17ff1a7 to
1803886
Compare
|
@bors r=cramertj as per #66592 (comment) |
|
📌 Commit 1803886 has been approved by |
bors
added
S-waiting-on-bors
Rework raw ident suggestions Use heuristics to determine whethersuggesting raw identifiers is appropriate. Account for raw identifiers when printing a path in a `use` suggestion. Fix #66126.
|
☀️ Test successful - checks-azure |
Use heuristics to determine whethersuggesting raw identifiers is
appropriate.
Account for raw identifiers when printing a path in a
usesuggestion.Fix #66126.