Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raw ident suggestion should only trigger if the code is otherwise well-formed #66126

Closed
estebank opened this issue Nov 5, 2019 · 1 comment · Fixed by #66592
Closed

Raw ident suggestion should only trigger if the code is otherwise well-formed #66126

estebank opened this issue Nov 5, 2019 · 1 comment · Fixed by #66592
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. D-papercut Diagnostics: An error or lint that needs small tweaks. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

estebank commented Nov 5, 2019

Right now the raw ident suggestion when using a reserved keyword somewhere where it is not allowed is context free, leading to misleading output:

https://twitter.com/isislovecruft/status/1191768296590315520

The parser should perform some lookahead to see if it could actually continue parsing if a raw identifier had been supplied in its place and if so, only then suggest raw idents.
@estebank estebank added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-papercut Diagnostics: An error or lint that needs small tweaks. D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. A-parser Area: The parsing of Rust source code to an AST P-low Low priority labels Nov 5, 2019
@petrochenkov
Copy link
Contributor

Or we shouldn't suggest using raw identifiers if we cannot do that easily and reliably.

@estebank estebank mentioned this issue Nov 20, 2019
Merged
@bors bors closed this as completed in 5a1d028 Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-incorrect Diagnostics: A diagnostic that is giving misleading or incorrect information. D-papercut Diagnostics: An error or lint that needs small tweaks. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework raw ident suggestions estebank/rust
2 participants
@estebank @petrochenkov