Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #64556

Closed
wants to merge 15 commits into from
Closed

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Sep 17, 2019

Successful merges:

Failed merges:

r? @ghost

nnethercote and others added 15 commits September 12, 2019 13:36
It's currently 120 bytes on x86-64, due to one oversized variant
(`Subtype`). This commit boxes `Subtype`'s contents, reducing the size
of `SubregionOrigin` to 32 bytes.

The change speeds things up by avoiding lots of `memcpy` calls, mostly
relating to `RegionConstraintData::constraints`, which is a `BTreeMap`
with `SubregionOrigin` values.
* Serialize the level to something a little more useful for a failure note
  struct
* Update tests accordingly
Co-Authored-By: Ralf Jung <post@ralfj.de>
Get rid of special const intrinsic query in favour of `const_eval`

r? @eddyb
… r=Mark-Simulacrum

Shrink `SubregionOrigin`.

It's currently 120 bytes on x86-64, due to one oversized variant
(`Subtype`). This commit boxes `Subtype`'s contents, reducing the size
of `SubregionOrigin` to 32 bytes.

The change speeds things up by avoiding lots of `memcpy` calls, mostly
relating to `RegionConstraintData::constraints`, which is a `BTreeMap`
with `SubregionOrigin` values.
…json-level, r=Mark-Simulacrum

Fix failure note `to_str` implementation

Serialize the level to something a little more useful for a failure note struct. This fixes rust-lang#60425.
…bini

avoid duplicate issues for Miri build failures

Currently, when Miri regressed from test-pass to test-fail, we pen an issue -- and then when it regresses further from test-fail to build-fail, we open a *second* issue.

This changes the logic to avoid the redundant second issue for Miri.

r? @pietroalbini @kennytm
…bini

build-manifest: re-add some comments

rust-lang#64543 also reverted the comments I added. This adds them back.
Includes rust-lang#64543.

r? @pietroalbini
@tmandry
Copy link
Member Author

tmandry commented Sep 17, 2019

@bors r+ p=7

@bors
Copy link
Contributor

bors commented Sep 17, 2019

📌 Commit 104f0fb has been approved by tmandry

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 17, 2019
@tmandry
Copy link
Member Author

tmandry commented Sep 17, 2019

Closing in favor of #64560

@tmandry tmandry closed this Sep 17, 2019
@tmandry
Copy link
Member Author

tmandry commented Sep 17, 2019

@bors r-

@tmandry tmandry deleted the rollup-jieilat branch September 17, 2019 21:03
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants