Fix failure note `to_str` implementation #64429

afnanenayet · 2019-09-13T13:50:21Z

Serialize the level to something a little more useful for a failure note struct. This fixes #60425.

rust-highfive · 2019-09-13T13:50:24Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

afnanenayet · 2019-09-13T16:47:59Z

I looked at the log output for the failing CI build...seems like a lot of errors that aren't related to my change, but I could be wrong. Does this normally happen?

Mark-Simulacrum · 2019-09-13T16:52:25Z

That's unexpected, but related to this change. We'll need to dig in why; I'll try to spend some time today on that.

Mark-Simulacrum · 2019-09-13T17:50:04Z

Oh, I see what's happening. The "For more information about this error" piece is being emitted as a failure note

rust/src/librustc_errors/lib.rs

Lines 692 to 701 in 3287a65

    
                               self.failure(&format!("Some errors have detailed explanations: {}{}", 
        
                                                     error_codes[..limit].join(", "), 
        
                                                     if error_codes.len() > 9 { "..." } else { "." })); 
        
                               self.failure(&format!("For more information about an error, try \ 
        
                                                      `rustc --explain {}`.", 
        
                                                     &error_codes[0])); 
        
                           } else { 
        
                               self.failure(&format!("For more information about this error, try \ 
        
                                                      `rustc --explain {}`.", 
        
                                                     &error_codes[0]));

I think adjusting the code here to not print the level_str if the level is FailureNote would work to fix CI here.

rust-highfive · 2019-09-15T21:05:12Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-15T20:54:13.7676224Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-15T20:54:13.7961912Z ##[command]git config gc.auto 0
2019-09-15T20:54:13.8079351Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-15T20:54:13.8140019Z ##[command]git config --get-all http.proxy
2019-09-15T20:54:13.8287254Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64429/merge:refs/remotes/pull/64429/merge
---
2019-09-15T21:02:26.8744965Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-09-15T21:02:27.4454367Z error[E0308]: mismatched types
2019-09-15T21:02:27.4454688Z     --> src/librustc_errors/emitter.rs:1150:44
2019-09-15T21:02:27.4454861Z      |
2019-09-15T21:02:27.4455085Z 1150 |             if Some(Level::FailureNote) != level {
2019-09-15T21:02:27.4455439Z      |                                            ^^^^^ expected enum `std::option::Option`, found &Level
2019-09-15T21:02:27.4455881Z      = note: expected type `std::option::Option<Level>`
2019-09-15T21:02:27.4455881Z      = note: expected type `std::option::Option<Level>`
2019-09-15T21:02:27.4456064Z                 found type `&Level`
2019-09-15T21:02:27.4918871Z error[E0308]: mismatched types
2019-09-15T21:02:27.4919302Z     --> src/librustc_errors/emitter.rs:1161:44
2019-09-15T21:02:27.4920137Z      |
2019-09-15T21:02:27.4920137Z      |
2019-09-15T21:02:27.4920466Z 1161 |             if Some(Level::FailureNote) != level {
2019-09-15T21:02:27.4921146Z      |                                            ^^^^^ expected enum `std::option::Option`, found &Level
2019-09-15T21:02:27.4921702Z      = note: expected type `std::option::Option<Level>`
2019-09-15T21:02:27.4921702Z      = note: expected type `std::option::Option<Level>`
2019-09-15T21:02:27.4921941Z                 found type `&Level`
2019-09-15T21:02:27.6423574Z error: aborting due to 2 previous errors
2019-09-15T21:02:27.6423650Z 
2019-09-15T21:02:27.6434799Z For more information about this error, try `rustc --explain E0308`.
2019-09-15T21:02:27.6566643Z error: Could not compile `rustc_errors`.
---
2019-09-15T21:02:29.7768442Z == clock drift check ==
2019-09-15T21:02:29.7787781Z   local time: Sun Sep 15 21:02:29 UTC 2019
2019-09-15T21:02:29.9281708Z   network time: Sun, 15 Sep 2019 21:02:29 GMT
2019-09-15T21:02:29.9286836Z == end clock drift check ==
2019-09-15T21:02:31.2105322Z ##[error]Bash exited with code '1'.
2019-09-15T21:02:31.2136730Z ##[section]Starting: Checkout
2019-09-15T21:02:31.2138309Z ==============================================================================
2019-09-15T21:02:31.2138353Z Task         : Get sources
2019-09-15T21:02:31.2138392Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-16T03:40:04Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-16T03:28:43.7486755Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-16T03:28:43.7676399Z ##[command]git config gc.auto 0
2019-09-16T03:28:43.7750480Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-16T03:28:43.7815349Z ##[command]git config --get-all http.proxy
2019-09-16T03:28:43.7973399Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64429/merge:refs/remotes/pull/64429/merge
---
2019-09-16T03:37:06.7932201Z     Checking arena v0.0.0 (/checkout/src/libarena)
2019-09-16T03:37:10.6822574Z    Compiling rustc_macros v0.1.0 (/checkout/src/librustc_macros)
2019-09-16T03:37:19.7346159Z     Checking syntax_pos v0.0.0 (/checkout/src/libsyntax_pos)
2019-09-16T03:37:21.2524896Z     Checking rustc_errors v0.0.0 (/checkout/src/librustc_errors)
2019-09-16T03:37:21.4023451Z error[E0425]: cannot find value `level_str` in this scope
2019-09-16T03:37:21.4024291Z      |
2019-09-16T03:37:21.4024291Z      |
2019-09-16T03:37:21.4024670Z 1170 |                 if !level_str.is_empty() {
2019-09-16T03:37:21.4027121Z 
2019-09-16T03:37:21.9948941Z error: aborting due to previous error
2019-09-16T03:37:21.9949177Z 
2019-09-16T03:37:21.9958935Z For more information about this error, try `rustc --explain E0425`.
---
2019-09-16T03:37:24.6079454Z == clock drift check ==
2019-09-16T03:37:24.6096974Z   local time: Mon Sep 16 03:37:24 UTC 2019
2019-09-16T03:37:25.0363880Z   network time: Mon, 16 Sep 2019 03:37:25 GMT
2019-09-16T03:37:25.0363966Z == end clock drift check ==
2019-09-16T03:37:26.4919263Z ##[error]Bash exited with code '1'.
2019-09-16T03:37:26.4956024Z ##[section]Starting: Checkout
2019-09-16T03:37:26.4958258Z ==============================================================================
2019-09-16T03:37:26.4958309Z Task         : Get sources
2019-09-16T03:37:26.4958352Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-16T05:16:04Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-16T03:56:34.0336738Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-16T03:56:34.0568783Z ##[command]git config gc.auto 0
2019-09-16T03:56:34.0634732Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-16T03:56:34.0669997Z ##[command]git config --get-all http.proxy
2019-09-16T03:56:34.0850202Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64429/merge:refs/remotes/pull/64429/merge
---
2019-09-16T05:03:45.2115937Z .................................................................................................... 1500/9020
2019-09-16T05:03:51.7031220Z .................................................................................................... 1600/9020
2019-09-16T05:04:05.5840483Z .............................................................i...............i...................... 1700/9020
2019-09-16T05:04:13.6104462Z .................................................................................................... 1800/9020
2019-09-16T05:04:30.7108983Z ....................................................iiiii........................................... 1900/9020
2019-09-16T05:04:43.0486036Z .................................................................................................... 2100/9020
2019-09-16T05:04:45.8982986Z .................................................................................................... 2200/9020
2019-09-16T05:04:49.7596036Z .................................................................................................... 2300/9020
2019-09-16T05:04:58.7558450Z .................................................................................................... 2400/9020
---
2019-09-16T05:08:15.1596057Z ........................................i...............i........................................... 4700/9020
2019-09-16T05:08:27.5423665Z .................................................................................................... 4800/9020
2019-09-16T05:08:34.8050202Z .................................................................................................... 4900/9020
2019-09-16T05:08:45.4987705Z .................................................................................................... 5000/9020
2019-09-16T05:08:53.7508518Z ........................ii.ii..............F........................................................ 5100/9020
2019-09-16T05:09:05.2928178Z ..........................................................................F......................... 5300/9020
2019-09-16T05:09:16.9844000Z ........................................................................................i........... 5400/9020
2019-09-16T05:09:25.8948892Z .................................................................................................... 5500/9020
2019-09-16T05:09:31.8257325Z .................................................................................................... 5600/9020
2019-09-16T05:09:31.8257325Z .................................................................................................... 5600/9020
2019-09-16T05:09:43.1376617Z ...................................................................................ii...i..ii....... 5700/9020
2019-09-16T05:10:11.1234483Z .................................................................................................... 5900/9020
2019-09-16T05:10:21.8827777Z .................................................................................................... 6000/9020
2019-09-16T05:10:21.8827777Z .................................................................................................... 6000/9020
2019-09-16T05:10:31.6769437Z .....................................................................................i..ii.......... 6100/9020
2019-09-16T05:11:05.9640231Z .................................................................................................... 6300/9020
2019-09-16T05:11:09.0231492Z ............................................i....................................................... 6400/9020
2019-09-16T05:11:11.4202217Z .................................................................................................... 6500/9020
2019-09-16T05:11:14.1980837Z ................i................................................................................... 6600/9020
---
2019-09-16T05:15:42.9179304Z 
2019-09-16T05:15:42.9183866Z ---- [ui] ui/json-short.rs stdout ----
2019-09-16T05:15:42.9190067Z diff of stderr:
2019-09-16T05:15:42.9191700Z 
2019-09-16T05:15:42.9193145Z 15 "}
2019-09-16T05:15:42.9247357Z 16 {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error
2019-09-16T05:15:42.9247461Z 17 "}
2019-09-16T05:15:42.9248171Z - {"message":"For more information about this error, try `rustc --explain E0601`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0601`.
2019-09-16T05:15:42.9248600Z + {"message":"For more information about this error, try `rustc --explain E0601`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0601`.
2019-09-16T05:15:42.9248936Z 19 "}
2019-09-16T05:15:42.9249011Z 
2019-09-16T05:15:42.9249052Z 
2019-09-16T05:15:42.9249100Z The actual stderr differed from the expected stderr.
2019-09-16T05:15:42.9249465Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short/json-short.stderr
2019-09-16T05:15:42.9249465Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short/json-short.stderr
2019-09-16T05:15:42.9249855Z To update references, rerun the tests and pass the `--bless` flag
2019-09-16T05:15:42.9250098Z To only update this specific test, also pass `--test-args json-short.rs`
2019-09-16T05:15:42.9250173Z error: 1 errors occurred comparing output.
2019-09-16T05:15:42.9250230Z status: exit code: 1
2019-09-16T05:15:42.9250230Z status: exit code: 1
2019-09-16T05:15:42.9251031Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/json-short.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--json=diagnostic-short" "--error-format=json" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/json-short/auxiliary" "-A" "unused"
2019-09-16T05:15:42.9251513Z ------------------------------------------
2019-09-16T05:15:42.9251545Z 
2019-09-16T05:15:42.9251768Z ------------------------------------------
2019-09-16T05:15:42.9251809Z stderr:
2019-09-16T05:15:42.9251809Z stderr:
2019-09-16T05:15:42.9252008Z ------------------------------------------
2019-09-16T05:15:42.9252385Z /checkout/src/test/ui/json-short.rs:2:63: error[E0601]: `main` function not found in crate `json_short`
2019-09-16T05:15:42.9252655Z For more information about this error, try `rustc --explain E0601`.
2019-09-16T05:15:42.9252699Z 
2019-09-16T05:15:42.9252896Z ------------------------------------------
2019-09-16T05:15:42.9252923Z 
2019-09-16T05:15:42.9252923Z 
2019-09-16T05:15:42.9252946Z 
2019-09-16T05:15:42.9253142Z ---- [ui] ui/lint/use_suggestion_json.rs stdout ----
2019-09-16T05:15:42.9253200Z diff of stderr:
2019-09-16T05:15:42.9253225Z 
2019-09-16T05:15:42.9253259Z 412 {
2019-09-16T05:15:42.9253510Z 413   "message": "For more information about this error, try `rustc --explain E0412`.",
2019-09-16T05:15:42.9253555Z 414   "code": null,
2019-09-16T05:15:42.9253723Z -   "level": "",
2019-09-16T05:15:42.9254270Z +   "level": "failure-note",
2019-09-16T05:15:42.9254338Z 416   "spans": [],
2019-09-16T05:15:42.9254378Z 417   "children": [],
2019-09-16T05:15:42.9254999Z 418   "rendered": "\u001b[0m\u001b[1mFor more information about this error, try `rustc --explain E0412`.\u001b[0m
2019-09-16T05:15:42.9255083Z 
2019-09-16T05:15:42.9255127Z The actual stderr differed from the expected stderr.
2019-09-16T05:15:42.9255443Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/use_suggestion_json.stderr
2019-09-16T05:15:42.9255443Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/use_suggestion_json/use_suggestion_json.stderr
2019-09-16T05:15:42.9255722Z To update references, rerun the tests and pass the `--bless` flag
2019-09-16T05:15:42.9255984Z To only update this specific test, also pass `--test-args lint/use_suggestion_json.rs`
2019-09-16T05:15:42.9256084Z error: 1 errors occurred comparing output.
2019-09-16T05:15:42.9256084Z error: 1 errors occurred comparing output.
2019-09-16T05:15:42.9256136Z failed to decode compiler output as json: line: {
2019-09-16T05:15:42.9256180Z output: {
2019-09-16T05:15:42.9256225Z   "message": "cannot find type `Iter` in this scope",
2019-09-16T05:15:42.9256286Z   "code": {
2019-09-16T05:15:42.9256330Z     "code": "E0412",
2019-09-16T05:15:42.9257714Z     "explanation": "\nThe type name used is not in scope.\n\nErroneous code examples:\n\n```compile_fail,E0412\nimpl Something {} // error: type name `Something` is not in scope\n\n// or:\n\ntrait Foo {\n    fn bar(N); // error: type name `N` is not in scope\n}\n\n// or:\n\nfn foo(x: T) {} // type name `T` is not in scope\n```\n\nTo fix this error, please verify you didn't misspell the type name, you did\ndeclare it or imported it into the scope. Examples:\n\n```\nstruct Something;\n\nimpl Something {} // ok!\n\n// or:\n\ntrait Foo {\n    type N;\n\n    fn bar(_: Self::N); // ok!\n}\n\n// or:\n\nfn foo<T>(x: T) {} // ok!\n```\n\nAnother case that causes this error is when a type is imported into a parent\nmodule. To fix this, you can follow the suggestion and use File directly or\n`use super::File;` which will import the types from the parent namespace. An\nexample that causes this error is below:\n\n```compile_fail,E0412\nuse std::fs::File;\n\nmod foo {\n    fn some_function(f: File) {}\n}\n```\n\n```\nuse std::fs::File;\n\nmod foo {\n    // either\n    use super::File;\n    // or\n    // use std::fs::File;\n    fn foo(f: File) {}\n}\n# fn main() {} // don't insert it for us; that'll break imports\n```\n"
2019-09-16T05:15:42.9258036Z   },
2019-09-16T05:15:42.9258079Z   "level": "error",
2019-09-16T05:15:42.9258132Z   "spans": [
2019-09-16T05:15:42.9258262Z       "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9258310Z       "byte_start": 471,
2019-09-16T05:15:42.9258370Z       "byte_end": 475,
2019-09-16T05:15:42.9258412Z       "line_start": 12,
2019-09-16T05:15:42.9258412Z       "line_start": 12,
2019-09-16T05:15:42.9258527Z       "line_end": 12,
2019-09-16T05:15:42.9258595Z       "column_start": 12,
2019-09-16T05:15:42.9258639Z       "column_end": 16,
2019-09-16T05:15:42.9258681Z       "is_primary": true,
2019-09-16T05:15:42.9258737Z       "text": [
2019-09-16T05:15:42.9258779Z         {
2019-09-16T05:15:42.9258823Z           "text": "    let x: Iter;",
2019-09-16T05:15:42.9258869Z           "highlight_start": 12,
2019-09-16T05:15:42.9258929Z           "highlight_end": 16
2019-09-16T05:15:42.9259011Z       ],
2019-09-16T05:15:42.9259011Z       ],
2019-09-16T05:15:42.9259070Z       "label": "not found in this scope",
2019-09-16T05:15:42.9259116Z       "suggested_replacement": null,
2019-09-16T05:15:42.9259169Z       "suggestion_applicability": null,
2019-09-16T05:15:42.9259214Z       "expansion": null
2019-09-16T05:15:42.9259306Z   ],
2019-09-16T05:15:42.9259306Z   ],
2019-09-16T05:15:42.9259347Z   "children": [
2019-09-16T05:15:42.9259402Z     {
2019-09-16T05:15:42.9259460Z       "message": "possible candidates are found in other modules, you can import them into scope",
2019-09-16T05:15:42.9259509Z       "code": null,
2019-09-16T05:15:42.9259570Z       "level": "help",
2019-09-16T05:15:42.9259612Z       "spans": [
2019-09-16T05:15:42.9259715Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9259763Z           "byte_start": 448,
2019-09-16T05:15:42.9259807Z           "byte_end": 448,
2019-09-16T05:15:42.9259851Z           "line_start": 11,
2019-09-16T05:15:42.9259851Z           "line_start": 11,
2019-09-16T05:15:42.9259912Z           "line_end": 11,
2019-09-16T05:15:42.9259954Z           "column_start": 1,
2019-09-16T05:15:42.9259997Z           "column_end": 1,
2019-09-16T05:15:42.9260062Z           "is_primary": true,
2019-09-16T05:15:42.9260105Z           "text": [
2019-09-16T05:15:42.9260146Z             {
2019-09-16T05:15:42.9260205Z               "text": "fn main() {",
2019-09-16T05:15:42.9260250Z               "highlight_start": 1,
2019-09-16T05:15:42.9260295Z               "highlight_end": 1
2019-09-16T05:15:42.9260846Z           ],
2019-09-16T05:15:42.9260888Z           "label": null,
2019-09-16T05:15:42.9260888Z           "label": null,
2019-09-16T05:15:42.9261058Z           "suggested_replacement": "use std::collections::binary_heap::Iter;\n\n",
2019-09-16T05:15:42.9261125Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9261170Z           "expansion": null
2019-09-16T05:15:42.9261264Z         {
2019-09-16T05:15:42.9262821Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9262906Z           "byte_start": 448,
2019-09-16T05:15:42.9262969Z           "byte_end": 448,
2019-09-16T05:15:42.9262969Z           "byte_end": 448,
2019-09-16T05:15:42.9263167Z           "line_start": 11,
2019-09-16T05:15:42.9263210Z           "line_end": 11,
2019-09-16T05:15:42.9263252Z           "column_start": 1,
2019-09-16T05:15:42.9263311Z           "column_end": 1,
2019-09-16T05:15:42.9263354Z           "is_primary": true,
2019-09-16T05:15:42.9263396Z           "text": [
2019-09-16T05:15:42.9263460Z             {
2019-09-16T05:15:42.9263503Z               "text": "fn main() {",
2019-09-16T05:15:42.9263673Z               "highlight_start": 1,
2019-09-16T05:15:42.9263715Z               "highlight_end": 1
2019-09-16T05:15:42.9264564Z           ],
2019-09-16T05:15:42.9264606Z           "label": null,
2019-09-16T05:15:42.9264606Z           "label": null,
2019-09-16T05:15:42.9264678Z           "suggested_replacement": "use std::collections::btree_map::Iter;\n\n",
2019-09-16T05:15:42.9264753Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9264813Z           "expansion": null
2019-09-16T05:15:42.9264925Z         {
2019-09-16T05:15:42.9264971Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9265386Z           "byte_start": 448,
2019-09-16T05:15:42.9265440Z           "byte_end": 448,
2019-09-16T05:15:42.9265440Z           "byte_end": 448,
2019-09-16T05:15:42.9265483Z           "line_start": 11,
2019-09-16T05:15:42.9265527Z           "line_end": 11,
2019-09-16T05:15:42.9265686Z           "column_start": 1,
2019-09-16T05:15:42.9265739Z           "column_end": 1,
2019-09-16T05:15:42.9265782Z           "is_primary": true,
2019-09-16T05:15:42.9265838Z           "text": [
2019-09-16T05:15:42.9265880Z             {
2019-09-16T05:15:42.9265922Z               "text": "fn main() {",
2019-09-16T05:15:42.9265981Z               "highlight_start": 1,
2019-09-16T05:15:42.9266026Z               "highlight_end": 1
2019-09-16T05:15:42.9266108Z           ],
2019-09-16T05:15:42.9266165Z           "label": null,
2019-09-16T05:15:42.9266165Z           "label": null,
2019-09-16T05:15:42.9266214Z           "suggested_replacement": "use std::collections::btree_set::Iter;\n\n",
2019-09-16T05:15:42.9266272Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9266333Z           "expansion": null
2019-09-16T05:15:42.9266415Z         {
2019-09-16T05:15:42.9266477Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9266530Z           "byte_start": 448,
2019-09-16T05:15:42.9266572Z           "byte_end": 448,
2019-09-16T05:15:42.9266572Z           "byte_end": 448,
2019-09-16T05:15:42.9266615Z           "line_start": 11,
2019-09-16T05:15:42.9266673Z           "line_end": 11,
2019-09-16T05:15:42.9266714Z           "column_start": 1,
2019-09-16T05:15:42.9266756Z           "column_end": 1,
2019-09-16T05:15:42.9266815Z           "is_primary": true,
2019-09-16T05:15:42.9266857Z           "text": [
2019-09-16T05:15:42.9266897Z             {
2019-09-16T05:15:42.9266954Z               "text": "fn main() {",
2019-09-16T05:15:42.9266999Z               "highlight_start": 1,
2019-09-16T05:15:42.9267049Z               "highlight_end": 1
2019-09-16T05:15:42.9267145Z           ],
2019-09-16T05:15:42.9267186Z           "label": null,
2019-09-16T05:15:42.9267186Z           "label": null,
2019-09-16T05:15:42.9267234Z           "suggested_replacement": "use std::collections::hash_map::Iter;\n\n",
2019-09-16T05:15:42.9267506Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9267571Z           "expansion": null
2019-09-16T05:15:42.9267675Z         {
2019-09-16T05:15:42.9267723Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9267770Z           "byte_start": 448,
2019-09-16T05:15:42.9267828Z           "byte_end": 448,
2019-09-16T05:15:42.9267828Z           "byte_end": 448,
2019-09-16T05:15:42.9267873Z           "line_start": 11,
2019-09-16T05:15:42.9267915Z           "line_end": 11,
2019-09-16T05:15:42.9267957Z           "column_start": 1,
2019-09-16T05:15:42.9268017Z           "column_end": 1,
2019-09-16T05:15:42.9268713Z           "is_primary": true,
2019-09-16T05:15:42.9268871Z           "text": [
2019-09-16T05:15:42.9268930Z             {
2019-09-16T05:15:42.9268972Z               "text": "fn main() {",
2019-09-16T05:15:42.9269014Z               "highlight_start": 1,
2019-09-16T05:15:42.9269071Z               "highlight_end": 1
2019-09-16T05:15:42.9269150Z           ],
2019-09-16T05:15:42.9269198Z           "label": null,
2019-09-16T05:15:42.9269198Z           "label": null,
2019-09-16T05:15:42.9269260Z           "suggested_replacement": "use std::collections::hash_set::Iter;\n\n",
2019-09-16T05:15:42.9269309Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9269353Z           "expansion": null
2019-09-16T05:15:42.9269445Z         {
2019-09-16T05:15:42.9269490Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9269550Z           "byte_start": 448,
2019-09-16T05:15:42.9269591Z           "byte_end": 448,
2019-09-16T05:15:42.9269591Z           "byte_end": 448,
2019-09-16T05:15:42.9269631Z           "line_start": 11,
2019-09-16T05:15:42.9269679Z           "line_end": 11,
2019-09-16T05:15:42.9269735Z           "column_start": 1,
2019-09-16T05:15:42.9269776Z           "column_end": 1,
2019-09-16T05:15:42.9269817Z           "is_primary": true,
2019-09-16T05:15:42.9270336Z           "text": [
2019-09-16T05:15:42.9270404Z             {
2019-09-16T05:15:42.9270444Z               "text": "fn main() {",
2019-09-16T05:15:42.9270607Z               "highlight_start": 1,
2019-09-16T05:15:42.9270659Z               "highlight_end": 1
2019-09-16T05:15:42.9270736Z           ],
2019-09-16T05:15:42.9270789Z           "label": null,
2019-09-16T05:15:42.9270789Z           "label": null,
2019-09-16T05:15:42.9270973Z           "suggested_replacement": "use std::collections::linked_list::Iter;\n\n",
2019-09-16T05:15:42.9271859Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9271940Z           "expansion": null
2019-09-16T05:15:42.9272016Z         {
2019-09-16T05:15:42.9272075Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9272134Z           "byte_start": 448,
2019-09-16T05:15:42.9272174Z           "byte_end": 448,
2019-09-16T05:15:42.9272174Z           "byte_end": 448,
2019-09-16T05:15:42.9272213Z           "line_start": 11,
2019-09-16T05:15:42.9272376Z           "line_end": 11,
2019-09-16T05:15:42.9272413Z           "column_start": 1,
2019-09-16T05:15:42.9272456Z           "column_end": 1,
2019-09-16T05:15:42.9272509Z           "is_primary": true,
2019-09-16T05:15:42.9272546Z           "text": [
2019-09-16T05:15:42.9272582Z             {
2019-09-16T05:15:42.9272668Z               "text": "fn main() {",
2019-09-16T05:15:42.9272824Z               "highlight_start": 1,
2019-09-16T05:15:42.9272866Z               "highlight_end": 1
2019-09-16T05:15:42.9272959Z           ],
2019-09-16T05:15:42.9272997Z           "label": null,
2019-09-16T05:15:42.9272997Z           "label": null,
2019-09-16T05:15:42.9273043Z           "suggested_replacement": "use std::collections::vec_deque::Iter;\n\n",
2019-09-16T05:15:42.9273105Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9273154Z           "expansion": null
2019-09-16T05:15:42.9273245Z         {
2019-09-16T05:15:42.9273289Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9273332Z           "byte_start": 448,
2019-09-16T05:15:42.9273393Z           "byte_end": 448,
2019-09-16T05:15:42.9273393Z           "byte_end": 448,
2019-09-16T05:15:42.9273435Z           "line_start": 11,
2019-09-16T05:15:42.9273474Z           "line_end": 11,
2019-09-16T05:15:42.9273513Z           "column_start": 1,
2019-09-16T05:15:42.9273568Z           "column_end": 1,
2019-09-16T05:15:42.9273608Z           "is_primary": true,
2019-09-16T05:15:42.9273648Z           "text": [
2019-09-16T05:15:42.9273700Z             {
2019-09-16T05:15:42.9273741Z               "text": "fn main() {",
2019-09-16T05:15:42.9273899Z               "highlight_start": 1,
2019-09-16T05:15:42.9273957Z               "highlight_end": 1
2019-09-16T05:15:42.9274177Z           ],
2019-09-16T05:15:42.9274218Z           "label": null,
2019-09-16T05:15:42.9274218Z           "label": null,
2019-09-16T05:15:42.9274278Z           "suggested_replacement": "use std::option::Iter;\n\n",
2019-09-16T05:15:42.9274381Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9274542Z           "expansion": null
2019-09-16T05:15:42.9274646Z         {
2019-09-16T05:15:42.9274694Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9274793Z           "byte_start": 448,
2019-09-16T05:15:42.9274839Z           "byte_end": 448,
2019-09-16T05:15:42.9274839Z           "byte_end": 448,
2019-09-16T05:15:42.9274963Z           "line_start": 11,
2019-09-16T05:15:42.9275005Z           "line_end": 11,
2019-09-16T05:15:42.9275062Z           "column_start": 1,
2019-09-16T05:15:42.9275105Z           "column_end": 1,
2019-09-16T05:15:42.9275148Z           "is_primary": true,
2019-09-16T05:15:42.9275206Z           "text": [
2019-09-16T05:15:42.9275248Z             {
2019-09-16T05:15:42.9275291Z               "text": "fn main() {",
2019-09-16T05:15:42.9275359Z               "highlight_start": 1,
2019-09-16T05:15:42.9275402Z               "highlight_end": 1
2019-09-16T05:15:42.9275484Z           ],
2019-09-16T05:15:42.9275545Z           "label": null,
2019-09-16T05:15:42.9275545Z           "label": null,
2019-09-16T05:15:42.9275670Z           "suggested_replacement": "use std::path::Iter;\n\n",
2019-09-16T05:15:42.9275730Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9275791Z           "expansion": null
2019-09-16T05:15:42.9275873Z         {
2019-09-16T05:15:42.9275936Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9275984Z           "byte_start": 448,
2019-09-16T05:15:42.9276026Z           "byte_end": 448,
2019-09-16T05:15:42.9276026Z           "byte_end": 448,
2019-09-16T05:15:42.9276085Z           "line_start": 11,
2019-09-16T05:15:42.9276128Z           "line_end": 11,
2019-09-16T05:15:42.9276171Z           "column_start": 1,
2019-09-16T05:15:42.9276214Z           "column_end": 1,
2019-09-16T05:15:42.9276281Z           "is_primary": true,
2019-09-16T05:15:42.9276324Z           "text": [
2019-09-16T05:15:42.9276365Z             {
2019-09-16T05:15:42.9276423Z               "text": "fn main() {",
2019-09-16T05:15:42.9276468Z               "highlight_start": 1,
2019-09-16T05:15:42.9276512Z               "highlight_end": 1
2019-09-16T05:15:42.9276617Z           ],
2019-09-16T05:15:42.9276658Z           "label": null,
2019-09-16T05:15:42.9276658Z           "label": null,
2019-09-16T05:15:42.9276706Z           "suggested_replacement": "use std::result::Iter;\n\n",
2019-09-16T05:15:42.9276771Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9276817Z           "expansion": null
2019-09-16T05:15:42.9276913Z         {
2019-09-16T05:15:42.9276960Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9277007Z           "byte_start": 448,
2019-09-16T05:15:42.9277066Z           "byte_end": 448,
2019-09-16T05:15:42.9277066Z           "byte_end": 448,
2019-09-16T05:15:42.9277117Z           "line_start": 11,
2019-09-16T05:15:42.9277159Z           "line_end": 11,
2019-09-16T05:15:42.9277201Z           "column_start": 1,
2019-09-16T05:15:42.9335788Z           "column_end": 1,
2019-09-16T05:15:42.9335893Z           "is_primary": true,
2019-09-16T05:15:42.9335942Z           "text": [
2019-09-16T05:15:42.9336033Z             {
2019-09-16T05:15:42.9336081Z               "text": "fn main() {",
2019-09-16T05:15:42.9336129Z               "highlight_start": 1,
2019-09-16T05:15:42.9336192Z               "highlight_end": 1
2019-09-16T05:15:42.9336279Z           ],
2019-09-16T05:15:42.9336322Z           "label": null,
2019-09-16T05:15:42.9336322Z           "label": null,
2019-09-16T05:15:42.9336388Z           "suggested_replacement": "use std::slice::Iter;\n\n",
2019-09-16T05:15:42.9336439Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9336486Z           "expansion": null
2019-09-16T05:15:42.9336803Z         {
2019-09-16T05:15:42.9336852Z           "file_name": "/checkout/src/test/ui/lint/use_suggestion_json.rs",
2019-09-16T05:15:42.9336915Z           "byte_start": 448,
2019-09-16T05:15:42.9336960Z           "byte_end": 448,
2019-09-16T05:15:42.9336960Z           "byte_end": 448,
2019-09-16T05:15:42.9337004Z           "line_start": 11,
2019-09-16T05:15:42.9337047Z           "line_end": 11,
2019-09-16T05:15:42.9337115Z           "column_start": 1,
2019-09-16T05:15:42.9337159Z           "column_end": 1,
2019-09-16T05:15:42.9337203Z           "is_primary": true,
2019-09-16T05:15:42.9337262Z           "text": [
2019-09-16T05:15:42.9337304Z             {
2019-09-16T05:15:42.9337348Z               "text": "fn main() {",
2019-09-16T05:15:42.9337409Z               "highlight_start": 1,
2019-09-16T05:15:42.9337455Z               "highlight_end": 1
2019-09-16T05:15:42.9337538Z           ],
2019-09-16T05:15:42.9337597Z           "label": null,
2019-09-16T05:15:42.9337597Z           "label": null,
2019-09-16T05:15:42.9337646Z           "suggested_replacement": "use std::sync::mpsc::Iter;\n\n",
2019-09-16T05:15:42.9337703Z           "suggestion_applicability": "Unspecified",
2019-09-16T05:15:42.9337767Z           "expansion": null
2019-09-16T05:15:42.9337851Z       ],
2019-09-16T05:15:42.9337851Z       ],
2019-09-16T05:15:42.9337908Z       "children": [],
2019-09-16T05:15:42.9337950Z       "rendered": null
2019-09-16T05:15:42.9338119Z   ],
2019-09-16T05:15:42.9338119Z   ],
2019-09-16T05:15:42.9341871Z   "rendered": "\u001b[0m\u001b[1m\u001b[38;5;9merror[E0412]\u001b[0m\u001b[0m\u001b[1m: cannot find type `Iter` in this scope\u001b[0m\n\u001b[0m  \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m--> \u001b[0m\u001b[0m/checkout/src/test/ui/lint/use_suggestion_json.rs:12:12\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m\n\u001b[0m\u001b[1m\u001b[38;5;12mLL\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0m    let x: Iter;\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0m           \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;9m^^^^\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;9mnot found in this scope\u001b[0m\n\u001b[0m\u001b[1m\u001b[38;5;14mhelp\u001b[0m\u001b[0m: possible candidates are found in other modules, you can import them into scope\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m\n\u001b[0m\u001b[1m\u001b[38;5;12mLL\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0muse std::collections::binary_heap::Iter;\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m\n\u001b[0m\u001b[1m\u001b[38;5;12mLL\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0muse std::collections::btree_map::Iter;\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m\n\u001b[0m\u001b[1m\u001b[38;5;12mLL\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0muse std::collections::btree_set::Iter;\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m\n\u001b[0m\u001b[1m\u001b[38;5;12mLL\u001b[0m\u001b[0m \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m| \u001b[0m\u001b[0muse std::collections::hash_map::Iter;\u001b[0m\n\u001b[0m   \u001b[0m\u001b[0m\u001b[1m\u001b[38;5;12m|\u001b[0m\n\u001b[0mand 8 other candidates\u001b[0m\n\n"
2019-09-16T05:15:42.9342309Z {
2019-09-16T05:15:42.9342309Z {
2019-09-16T05:15:42.9342360Z   "message": "aborting due to previous error",
2019-09-16T05:15:42.9342421Z   "code": null,
2019-09-16T05:15:42.9342469Z   "level": "error",
2019-09-16T05:15:42.9342511Z   "spans": [],
2019-09-16T05:15:42.9342567Z   "children": [],
2019-09-16T05:15:42.9342622Z   "rendered": "\u001b[0m\u001b[1m\u001b[38;5;9merror\u001b[0m\u001b[0m\u001b[1m: aborting due to previous error\u001b[0m\n\n"
2019-09-16T05:15:42.9342728Z {
2019-09-16T05:15:42.9342728Z {
2019-09-16T05:15:42.9343142Z   "message": "For more information about this error, try `rustc --explain E0412`.",
2019-09-16T05:15:42.9343194Z   "code": null,
2019-09-16T05:15:42.9344191Z   "level": "failure-note",
2019-09-16T05:15:42.9344439Z   "spans": [],
2019-09-16T05:15:42.9344481Z   "children": [],
2019-09-16T05:15:42.9345206Z   "rendered": "\u001b[0m\u001b[1mFor more information about this error, try `rustc --explain E0412`.\u001b[0m\n"
2019-09-16T05:15:42.9345901Z thread '[ui] ui/lint/use_suggestion_json.rs' panicked at 'explicit panic', src/tools/compiletest/src/json.rs:87:21
2019-09-16T05:15:42.9345977Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-16T05:15:42.9346032Z 
2019-09-16T05:15:42.9346057Z 
---
2019-09-16T05:15:42.9346731Z 
2019-09-16T05:15:42.9346990Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-16T05:15:42.9347088Z 
2019-09-16T05:15:42.9347116Z 
2019-09-16T05:15:42.9353890Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-16T05:15:42.9354174Z 
2019-09-16T05:15:42.9354220Z 
2019-09-16T05:15:42.9354267Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-16T05:15:42.9354318Z Build completed unsuccessfully in 1:11:35
2019-09-16T05:15:42.9354318Z Build completed unsuccessfully in 1:11:35
2019-09-16T05:15:42.9354543Z == clock drift check ==
2019-09-16T05:15:42.9369085Z   local time: Mon Sep 16 05:15:42 UTC 2019
2019-09-16T05:15:43.1006365Z   network time: Mon, 16 Sep 2019 05:15:43 GMT
2019-09-16T05:15:43.1006459Z == end clock drift check ==
2019-09-16T05:15:43.9872814Z ##[error]Bash exited with code '1'.
2019-09-16T05:15:43.9915685Z ##[section]Starting: Checkout
2019-09-16T05:15:43.9917686Z ==============================================================================
2019-09-16T05:15:43.9917741Z Task         : Get sources
2019-09-16T05:15:43.9917789Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-16T08:52:03Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-16T07:18:51.8234358Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-16T07:18:51.8506815Z ##[command]git config gc.auto 0
2019-09-16T07:18:51.8541294Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-16T07:18:51.8609434Z ##[command]git config --get-all http.proxy
2019-09-16T07:18:51.8760792Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64429/merge:refs/remotes/pull/64429/merge
---
2019-09-16T08:25:19.5505936Z .................................................................................................... 1500/9020
2019-09-16T08:25:26.0395016Z .................................................................................................... 1600/9020
2019-09-16T08:25:39.4969297Z .............................................................i...............i...................... 1700/9020
2019-09-16T08:25:47.2811201Z .................................................................................................... 1800/9020
2019-09-16T08:26:03.8318491Z ....................................................iiiii........................................... 1900/9020
2019-09-16T08:26:15.9085359Z .................................................................................................... 2100/9020
2019-09-16T08:26:18.6900155Z .................................................................................................... 2200/9020
2019-09-16T08:26:22.4031327Z .................................................................................................... 2300/9020
2019-09-16T08:26:31.0766003Z .................................................................................................... 2400/9020
---
2019-09-16T08:29:42.3864887Z ........................................i...............i........................................... 4700/9020
2019-09-16T08:29:54.4344305Z .................................................................................................... 4800/9020
2019-09-16T08:30:01.6877386Z .................................................................................................... 4900/9020
2019-09-16T08:30:12.1064435Z .................................................................................................... 5000/9020
2019-09-16T08:30:19.9606738Z ........................ii.ii....................................................................... 5100/9020
2019-09-16T08:30:31.1998185Z .................................................................................................... 5300/9020
2019-09-16T08:30:41.9539773Z ........................................................................................i........... 5400/9020
2019-09-16T08:30:50.6256488Z .................................................................................................... 5500/9020
2019-09-16T08:30:56.3834903Z .................................................................................................... 5600/9020
2019-09-16T08:30:56.3834903Z .................................................................................................... 5600/9020
2019-09-16T08:31:07.5040242Z ...................................................................................ii...i..ii....... 5700/9020
2019-09-16T08:31:34.7411564Z .................................................................................................... 5900/9020
2019-09-16T08:31:45.2071342Z .................................................................................................... 6000/9020
2019-09-16T08:31:45.2071342Z .................................................................................................... 6000/9020
2019-09-16T08:31:53.9211442Z .....................................................................................i..ii.......... 6100/9020
2019-09-16T08:32:25.8135668Z .................................................................................................... 6300/9020
2019-09-16T08:32:28.9627160Z ............................................i....................................................... 6400/9020
2019-09-16T08:32:31.3629128Z .................................................................................................... 6500/9020
2019-09-16T08:32:34.1401321Z ................i................................................................................... 6600/9020
---
2019-09-16T08:37:25.9541255Z  finished in 5.453
2019-09-16T08:37:25.9541592Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-16T08:37:25.9541632Z 
2019-09-16T08:37:25.9541677Z running 150 tests
2019-09-16T08:37:28.9502849Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/150
2019-09-16T08:37:31.0478126Z ..iiii..............i.........iii.i.......ii......
2019-09-16T08:37:31.0479613Z 
2019-09-16T08:37:31.0479717Z  finished in 5.797
2019-09-16T08:37:31.0678700Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-16T08:37:31.2583003Z 
---
2019-09-16T08:37:33.9603872Z  finished in 2.357
2019-09-16T08:37:33.9604556Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-16T08:37:33.9604633Z 
2019-09-16T08:37:33.9604679Z running 9 tests
2019-09-16T08:37:33.9605218Z iiiiiiiii
2019-09-16T08:37:33.9605613Z 
2019-09-16T08:37:33.9605656Z  finished in 0.179
2019-09-16T08:37:33.9605960Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-16T08:37:33.9605997Z 
---
2019-09-16T08:37:53.9562459Z  finished in 19.805
2019-09-16T08:37:53.9562876Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-16T08:37:53.9562923Z 
2019-09-16T08:37:53.9562996Z running 123 tests
2019-09-16T08:38:20.2863471Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-16T08:38:25.3757999Z i.i.i......iii.i.....ii
2019-09-16T08:38:25.3759382Z 
2019-09-16T08:38:25.3764413Z  finished in 31.901
2019-09-16T08:38:25.3775372Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-16T08:38:25.3776345Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-16T08:51:48.8871269Z .................................................................................................... 400/459
2019-09-16T08:51:57.7154335Z ...........................................................
2019-09-16T08:51:57.7154773Z failures:
2019-09-16T08:51:57.7154898Z 
2019-09-16T08:51:57.7155777Z ---- prelude/mod.rs - prelude (line 6) stdout ----
2019-09-16T08:51:57.7192900Z error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
2019-09-16T08:51:57.7194062Z  --> prelude/mod.rs:8:1
2019-09-16T08:51:57.7194485Z 5 | extern crate alloc;
2019-09-16T08:51:57.7194649Z   | ^^^^^^^^^^^^^^^^^^^
2019-09-16T08:51:57.7194765Z 
2019-09-16T08:51:57.7194922Z error: aborting due to previous error
2019-09-16T08:51:57.7194922Z error: aborting due to previous error
2019-09-16T08:51:57.7195037Z 
2019-09-16T08:51:57.7195396Z Couldn't compile the test.
2019-09-16T08:51:57.7195856Z ---- raw_vec.rs - raw_vec::RawVec<T, A>::double (line 261) stdout ----
2019-09-16T08:51:57.7196399Z error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
2019-09-16T08:51:57.7196810Z  --> raw_vec.rs:263:1
2019-09-16T08:51:57.7197125Z 4 | extern crate alloc;
2019-09-16T08:51:57.7197641Z   | ^^^^^^^^^^^^^^^^^^^
2019-09-16T08:51:57.7197763Z 
2019-09-16T08:51:57.7197896Z error: aborting due to previous error
2019-09-16T08:51:57.7197896Z error: aborting due to previous error
2019-09-16T08:51:57.7198008Z 
2019-09-16T08:51:57.7198418Z Couldn't compile the test.
2019-09-16T08:51:57.7198849Z ---- raw_vec.rs - raw_vec::RawVec<T, A>::reserve (line 466) stdout ----
2019-09-16T08:51:57.7199360Z error[E0523]: found two different crates with name `alloc` that are not distinguished by differing `-C metadata`. This will result in symbol conflicts between the two.
2019-09-16T08:51:57.7200100Z  --> raw_vec.rs:468:1
2019-09-16T08:51:57.7200531Z 4 | extern crate alloc;
2019-09-16T08:51:57.7200668Z   | ^^^^^^^^^^^^^^^^^^^
2019-09-16T08:51:57.7200779Z 
2019-09-16T08:51:57.7200913Z error: aborting due to previous error
---
2019-09-16T08:51:57.7203763Z 
2019-09-16T08:51:57.7212506Z error: test failed, to rerun pass '--doc'
2019-09-16T08:51:57.7230942Z 
2019-09-16T08:51:57.7231111Z 
2019-09-16T08:51:57.7232019Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--" "--quiet"
2019-09-16T08:51:57.7232438Z 
2019-09-16T08:51:57.7232477Z 
2019-09-16T08:51:57.7237376Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-16T08:51:57.7237661Z Build completed unsuccessfully in 1:25:45
2019-09-16T08:51:57.7237661Z Build completed unsuccessfully in 1:25:45
2019-09-16T08:51:57.7328551Z == clock drift check ==
2019-09-16T08:51:58.5749023Z   local time: Mon Sep 16 08:51:57 UTC 2019
2019-09-16T08:51:58.5749452Z   network time: Mon, 16 Sep 2019 08:51:57 GMT
2019-09-16T08:51:58.5749550Z == end clock drift check ==
2019-09-16T08:51:58.5816975Z ##[error]Bash exited with code '1'.
2019-09-16T08:51:58.5857980Z ##[section]Starting: Checkout
2019-09-16T08:51:58.5859837Z ==============================================================================
2019-09-16T08:51:58.5859891Z Task         : Get sources
2019-09-16T08:51:58.5859957Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

afnanenayet · 2019-09-16T14:54:45Z

@Mark-Simulacrum how can I re-run the CI? I saw the issue that references the build error that just happened for this PR

Mark-Simulacrum

r=me with nit fixed

src/librustc_errors/emitter.rs

Mark-Simulacrum · 2019-09-16T17:57:29Z

Ah, and we'll also want to squash the commits into just one. Thanks!

afnanenayet · 2019-09-16T23:19:22Z

Awesome, I'll fix this up after work. Thanks so much for helping me out with this!

* Serialize the level to something a little more useful for a failure note struct * Update tests accordingly

Mark-Simulacrum · 2019-09-17T10:47:30Z

Thanks!

@bors r+ rollup

bors · 2019-09-17T10:47:31Z

📌 Commit 02c1b89 has been approved by Mark-Simulacrum

…json-level, r=Mark-Simulacrum Fix failure note `to_str` implementation Serialize the level to something a little more useful for a failure note struct. This fixes rust-lang#60425.

@ghost

Rollup of 10 pull requests Successful merges: - #61626 (Get rid of special const intrinsic query in favour of `const_eval`) - #64283 (Updated RELEASES.md for 1.38.0) - #64394 (Shrink `SubregionOrigin`.) - #64429 (Fix failure note `to_str` implementation) - #64436 (improve Vec example soundness in mem::transmute docs) - #64502 (avoid duplicate issues for Miri build failures) - #64505 (Fix inconsistent link formatting) - #64529 (Add an example to Pin::as_mut) - #64541 (document Miri error categories) - #64544 (build-manifest: re-add some comments) Failed merges: r? @ghost

rust-highfive assigned petrochenkov Sep 13, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019

Centril mentioned this pull request Sep 16, 2019

Spurious "found two different crates with name alloc" errors in PR builder #64389

Closed

Mark-Simulacrum approved these changes Sep 16, 2019

View reviewed changes

src/librustc_errors/emitter.rs Outdated Show resolved Hide resolved

Mark-Simulacrum assigned Mark-Simulacrum and unassigned petrochenkov Sep 16, 2019

Fix failure note to_str implementation

02c1b89

* Serialize the level to something a little more useful for a failure note struct * Update tests accordingly

afnanenayet force-pushed the afnan/fix-failure-note-json-level branch from 4436338 to 02c1b89 Compare September 17, 2019 05:31

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2019

tmandry mentioned this pull request Sep 17, 2019

Rollup of 7 pull requests #64556

Closed

tmandry mentioned this pull request Sep 17, 2019

Rollup of 8 pull requests #64560

Closed

tmandry mentioned this pull request Sep 17, 2019

Rollup of 10 pull requests #64562

Merged

bors merged commit 02c1b89 into rust-lang:master Sep 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix failure note `to_str` implementation #64429

Fix failure note `to_str` implementation #64429

afnanenayet commented Sep 13, 2019

rust-highfive commented Sep 13, 2019

afnanenayet commented Sep 13, 2019

Mark-Simulacrum commented Sep 13, 2019

Mark-Simulacrum commented Sep 13, 2019

rust-highfive commented Sep 15, 2019

rust-highfive commented Sep 16, 2019

rust-highfive commented Sep 16, 2019

rust-highfive commented Sep 16, 2019

afnanenayet commented Sep 16, 2019

Mark-Simulacrum left a comment

Mark-Simulacrum commented Sep 16, 2019

afnanenayet commented Sep 16, 2019

Mark-Simulacrum commented Sep 17, 2019

bors commented Sep 17, 2019

Fix failure note to_str implementation #64429

Fix failure note to_str implementation #64429

Conversation

afnanenayet commented Sep 13, 2019

rust-highfive commented Sep 13, 2019

afnanenayet commented Sep 13, 2019

Mark-Simulacrum commented Sep 13, 2019

Mark-Simulacrum commented Sep 13, 2019

rust-highfive commented Sep 15, 2019

rust-highfive commented Sep 16, 2019

rust-highfive commented Sep 16, 2019

rust-highfive commented Sep 16, 2019

afnanenayet commented Sep 16, 2019

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Mark-Simulacrum commented Sep 16, 2019

afnanenayet commented Sep 16, 2019

Mark-Simulacrum commented Sep 17, 2019

bors commented Sep 17, 2019

Fix failure note `to_str` implementation #64429

Fix failure note `to_str` implementation #64429