Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trailing comma in macro 2.0 declarations. #63198

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Allow trailing comma in macro 2.0 declarations. #63198

merged 2 commits into from
Aug 2, 2019

Conversation

rbartlensky
Copy link
Contributor

This should hopefully close #63102.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2019
@petrochenkov
Copy link
Contributor

Could you add a // check-pass test into src/test/ui/macros making sure that this works?

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 1, 2019
@rbartlensky
Copy link
Contributor Author

@petrochenkov Pushed a commit which adds a test. Let me know if I need to add anything else to it!

@petrochenkov
Copy link
Contributor

Everything looks good, thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 2, 2019

📌 Commit 2aa368a has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 2, 2019
@Centril
Rollup merge of rust-lang#63198 - rbartlensky:fix-macro-trailing-comm…
89dce46 
…a, r=petrochenkov

Allow trailing comma in macro 2.0 declarations.

This should hopefully close rust-lang#63102.
@Centril Centril mentioned this pull request Aug 2, 2019
Merged
bors added a commit that referenced this pull request Aug 2, 2019
@bors
Auto merge of #63214 - Centril:rollup-hdb7dnx, r=Centril
1df512f 
Rollup of 7 pull requests

Successful merges:

 - #62663 (More questionmarks in doctests)
 - #62969 (Changing the structure of `mir::interpret::InterpError`)
 - #63153 (Remove redundant method with const variable resolution)
 - #63189 (Doc improvements)
 - #63198 (Allow trailing comma in macro 2.0 declarations.)
 - #63202 (Fix ICE in #63135)
 - #63203 (Make is_mutable use PlaceRef instead of it's fields)

Failed merges:

r? @ghost
@bors bors merged commit 2aa368a into rust-lang:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

decl macro 2.0 doesn't allow trailing comma
4 participants
@rbartlensky @rust-highfive @petrochenkov @bors