Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc improvements #63189

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Doc improvements #63189

merged 4 commits into from
Aug 2, 2019

Conversation

waywardmonkeys
Copy link
Contributor

Miscellaneous documentation fixes.

@rust-highfive
Copy link
Collaborator

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-08-01T08:16:11.6111204Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-01T08:16:11.6335080Z ##[command]git config gc.auto 0
2019-08-01T08:16:11.6442137Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-01T08:16:11.6508580Z ##[command]git config --get-all http.proxy
2019-08-01T08:16:11.6641912Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/63189/merge:refs/remotes/pull/63189/merge
---
2019-08-01T08:16:47.9774019Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-01T08:16:47.9774052Z 
2019-08-01T08:16:47.9774282Z   git checkout -b <new-branch-name>
2019-08-01T08:16:47.9774316Z 
2019-08-01T08:16:47.9774385Z HEAD is now at f4c40a672 Merge c1c5dae3fc62b8ca9b75e01c3ae5c330ccd1e136 into 8a58268b5ad9c4a240be349a633069d48991eb0c
2019-08-01T08:16:47.9929569Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-01T08:16:47.9932963Z ==============================================================================
2019-08-01T08:16:47.9933032Z Task         : Bash
2019-08-01T08:16:47.9933102Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-01T09:18:33.1096972Z .................................................................................................... 1400/8819
2019-08-01T09:18:39.0664181Z .................................................................................................... 1500/8819
2019-08-01T09:18:51.7798837Z .................................................................i...............i.................. 1600/8819
2019-08-01T09:18:59.3636342Z .................................................................................................... 1700/8819
2019-08-01T09:19:14.5473327Z ...................................................iiiii............................................ 1800/8819
2019-08-01T09:19:25.8459300Z .................................................................................................... 2000/8819
2019-08-01T09:19:28.4310704Z .................................................................................................... 2100/8819
2019-08-01T09:19:32.1126961Z .................................................................................................... 2200/8819
2019-08-01T09:19:38.6758518Z .................................................................................................... 2300/8819
---
2019-08-01T09:23:36.9196555Z .................................................................................................... 5300/8819
2019-08-01T09:23:44.3110190Z ..............i..................................................................................... 5400/8819
2019-08-01T09:23:50.0308780Z .................................................................................................... 5500/8819
2019-08-01T09:24:02.6092370Z .................................................................................................... 5600/8819
2019-08-01T09:24:16.2594498Z ........ii...i..ii...........i...................................................................... 5700/8819
2019-08-01T09:24:31.8808748Z .................................................................................................... 5900/8819
2019-08-01T09:24:36.7847264Z .................................................................................................... 6000/8819
2019-08-01T09:24:36.7847264Z .................................................................................................... 6000/8819
2019-08-01T09:24:51.0029494Z ........i..ii....................................................................................... 6100/8819
2019-08-01T09:25:10.5505726Z ...................................................i................................................ 6300/8819
2019-08-01T09:25:12.7637013Z .................................................................................................... 6400/8819
2019-08-01T09:25:15.2994393Z .....................i.............................................................................. 6500/8819
2019-08-01T09:25:19.9220769Z .................................................................................................... 6600/8819
---
2019-08-01T09:30:01.9362570Z  finished in 22.712
2019-08-01T09:30:01.9546564Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:30:02.1206828Z 
2019-08-01T09:30:02.1207139Z running 146 tests
2019-08-01T09:30:05.4100316Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-01T09:30:07.2716184Z iii..............i.........iii.i......ii......
2019-08-01T09:30:07.2717646Z 
2019-08-01T09:30:07.2721502Z  finished in 5.317
2019-08-01T09:30:07.2913251Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:30:07.4685929Z 
---
2019-08-01T09:30:09.5211619Z  finished in 2.230
2019-08-01T09:30:09.5391861Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:30:09.7026158Z 
2019-08-01T09:30:09.7026901Z running 9 tests
2019-08-01T09:30:09.7027769Z iiiiiiiii
2019-08-01T09:30:09.7028415Z 
2019-08-01T09:30:09.7028642Z  finished in 0.163
2019-08-01T09:30:09.7206091Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:30:09.8880471Z 
---
2019-08-01T09:30:28.2832054Z  finished in 18.562
2019-08-01T09:30:28.3025687Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:30:28.4696653Z 
2019-08-01T09:30:28.4696935Z running 122 tests
2019-08-01T09:30:53.6951151Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-01T09:30:58.5810825Z .i.i......iii.i.....ii
2019-08-01T09:30:58.5812052Z 
2019-08-01T09:30:58.5816090Z  finished in 30.279
2019-08-01T09:30:58.5824425Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:30:58.5825105Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-01T09:45:22.2399866Z 
2019-08-01T09:45:22.2400677Z    Doc-tests core
2019-08-01T09:45:26.4274814Z 
2019-08-01T09:45:26.4275870Z running 2379 tests
2019-08-01T09:45:38.8927466Z ......iiiii......................................................................................... 100/2379
2019-08-01T09:45:51.3255193Z .........................................................................ii......................... 200/2379
2019-08-01T09:46:21.0437255Z .................................................................................................... 400/2379
2019-08-01T09:46:21.0437255Z .................................................................................................... 400/2379
2019-08-01T09:46:32.2844758Z ..............................i..i.................iiii............................................. 500/2379
2019-08-01T09:46:56.0093631Z .................................................................................................... 700/2379
2019-08-01T09:47:08.0578761Z .................................................................................................... 800/2379
2019-08-01T09:47:20.1414616Z .................................................................................................... 900/2379
2019-08-01T09:47:32.1499174Z .................................................................................................... 1000/2379
---
2019-08-01T09:52:38.8284013Z ............................................... 300/756
2019-08-01T09:52:38.8288516Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/io/stdio.rs:854:13
2019-08-01T09:52:38.9952969Z .................................................................................................... 400/756
2019-08-01T09:52:41.0788311Z .................................................................................................... 500/756
2019-08-01T09:52:41.0999465Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-01T09:52:41.1038803Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-08-01T09:52:41.1053959Z ......thread '<unnamed>.' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-01T09:52:41.1059076Z .thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-01T09:52:41.3141475Z ........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-01T09:52:41.3143822Z .....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-01T09:52:41.3157114Z ......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-08-01T09:52:43.3819231Z ...............thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-08-01T09:52:43.3819796Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
2019-08-01T09:52:43.3823006Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:561:13
2019-08-01T09:52:43.3824740Z .thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:689:13
---
2019-08-01T09:52:52.8912423Z 
2019-08-01T09:52:52.8912657Z running 989 tests
2019-08-01T09:53:17.0099225Z i................................................................................................... 100/989
2019-08-01T09:53:30.2118859Z .................................................................................................... 200/989
2019-08-01T09:53:39.2409684Z .................iii......i......i...i......i....................................................... 300/989
2019-08-01T09:53:44.2514015Z .................................................................................................... 400/989
2019-08-01T09:53:52.5588268Z ................................i..i.................................ii............................. 500/989
2019-08-01T09:54:07.7443371Z .................................................................................................... 700/989
2019-08-01T09:54:07.7443371Z .................................................................................................... 700/989
2019-08-01T09:54:16.5368441Z ...............iiii................................................................................. 800/989
2019-08-01T09:54:31.2858311Z .................................................................................................... 900/989
2019-08-01T09:54:39.0599401Z .....................................iiii................................................
2019-08-01T09:54:39.0601945Z 
2019-08-01T09:54:39.0816707Z  finished in 248.211
2019-08-01T09:54:39.0834968Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-01T09:54:39.2784091Z     Finished release [optimized] target(s) in 0.19s
---
2019-08-01T10:14:13.1170586Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2019-08-01T10:14:13.5078386Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2019-08-01T10:14:13.7017926Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2019-08-01T10:14:15.8143367Z     Finished release [optimized] target(s) in 2.30s
2019-08-01T10:14:16.5371628Z std/array/trait.FixedSizeArray.html:11: broken link - std/array/trait.AsRef.html
2019-08-01T10:14:16.5372048Z std/array/trait.FixedSizeArray.html:11: broken link - std/array/trait.AsMut.html
2019-08-01T10:14:22.3888539Z core/array/trait.FixedSizeArray.html:11: broken link - core/array/trait.AsRef.html
2019-08-01T10:14:22.3890505Z core/array/trait.FixedSizeArray.html:11: broken link - core/array/trait.AsMut.html
2019-08-01T10:14:24.4111298Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:39:9
2019-08-01T10:14:24.4111593Z 
2019-08-01T10:14:24.4111620Z 
2019-08-01T10:14:24.4112023Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2019-08-01T10:14:24.4116203Z expected success, got: exit code: 101
2019-08-01T10:14:24.4116203Z expected success, got: exit code: 101
2019-08-01T10:14:24.4116380Z 
2019-08-01T10:14:24.4116685Z 
2019-08-01T10:14:24.4128097Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-01T10:14:24.4128437Z Build completed unsuccessfully in 1:51:08
2019-08-01T10:14:27.0987195Z ##[error]Bash exited with code '1'.
2019-08-01T10:14:27.1023285Z ##[section]Starting: Checkout
2019-08-01T10:14:27.1025031Z ==============================================================================
2019-08-01T10:14:27.1025228Z Task         : Get sources
2019-08-01T10:14:27.1025275Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@waywardmonkeys
Copy link
Contributor Author

Woops. Did a force push that should fix that failure.

@Centril
Copy link
Contributor

Centril commented Aug 1, 2019

r? @Centril r=me rollup when-green

@rust-highfive rust-highfive assigned Centril and unassigned KodrAus Aug 1, 2019
@waywardmonkeys
Copy link
Contributor Author

This should be good to go now.

@Centril
Copy link
Contributor

Centril commented Aug 2, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 2, 2019

📌 Commit 325c6a5 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 2, 2019
@Centril
Rollup merge of rust-lang#63189 - waywardmonkeys:doc-improvements, r=…
dbfe12d 
…Centril

Doc improvements

Miscellaneous documentation fixes.
@Centril Centril mentioned this pull request Aug 2, 2019
Merged
bors added a commit that referenced this pull request Aug 2, 2019
@bors
Auto merge of #63214 - Centril:rollup-hdb7dnx, r=Centril
1df512f 
Rollup of 7 pull requests

Successful merges:

 - #62663 (More questionmarks in doctests)
 - #62969 (Changing the structure of `mir::interpret::InterpError`)
 - #63153 (Remove redundant method with const variable resolution)
 - #63189 (Doc improvements)
 - #63198 (Allow trailing comma in macro 2.0 declarations.)
 - #63202 (Fix ICE in #63135)
 - #63203 (Make is_mutable use PlaceRef instead of it's fields)

Failed merges:

r? @ghost
@bors bors merged commit 325c6a5 into rust-lang:master Aug 2, 2019
@waywardmonkeys waywardmonkeys deleted the doc-improvements branch October 1, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@waywardmonkeys @rust-highfive @Centril @bors @KodrAus