Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RELEASES.md for 1.37.0 #62653
Updated RELEASES.md for 1.37.0 #62653
Changes from 3 commits
d24927d
795a2fe
d505426
70685ef
b7a29c0
9994ca5
f2f4c0e
6b0f4c6
f695906
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This arguably is the most important language change so I would put it first. Then I would mention consts, then Repr align. Also, I would use an example with Self here since that is likely the most common use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that arbitrary reordering does not provide much benefit in the RELEASES.md document. This is really the point of the blog post to highlight specific features and guide a user through a new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reordering is not arbitrary, it's based on the relative importance of the features by estimating how many users will be affected and benefit from each one.
If so then we can dispense with examples in the release notes altogether. I think the blog post does a good job of talking in-depth about the most important bits but some users will read the release notes as well and we should use that opportunity wisely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be important if the entire section was longer, but it isn't. It fits entirely on the page on all devices except mobile. Personally I find this to be pointless busy work, and I'm not going to do it. If you think it's that important feel free to make a separate PR.