Updated RELEASES.md for 1.37.0 #62653
Conversation
rust-highfive
added
the
S-waiting-on-review
XAMPPRocky
added
C-enhancement
kennytm
added
the
beta-nominated
Co-Authored-By: kennytm <kennytm@gmail.com>
| - [`#[must_use]` will now warn if the type is in a array and unused.][62235] | ||
| - [You can now use the `cfg` and `cfg_attr` attributes on | ||
| generic parameters.][61547] | ||
| - [You can now use enum variants through type alias.][61682] e.g. You can |
There was a problem hiding this comment.
This arguably is the most important language change so I would put it first. Then I would mention consts, then Repr align. Also, I would use an example with Self here since that is likely the most common use.
There was a problem hiding this comment.
I think that arbitrary reordering does not provide much benefit in the RELEASES.md document. This is really the point of the blog post to highlight specific features and guide a user through a new release.
There was a problem hiding this comment.
The reordering is not arbitrary, it's based on the relative importance of the features by estimating how many users will be affected and benefit from each one.
This is really the point of the blog post to highlight specific features and guide a user through a new release.
If so then we can dispense with examples in the release notes altogether. I think the blog post does a good job of talking in-depth about the most important bits but some users will read the release notes as well and we should use that opportunity wisely.
There was a problem hiding this comment.
The reordering is not arbitrary, it's based on the relative importance of the features by estimating how many users will be affected and benefit from each one.
This would be important if the entire section was longer, but it isn't. It fits entirely on the page on all devices except mobile. Personally I find this to be pointless busy work, and I'm not going to do it. If you think it's that important feel free to make a separate PR.
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
|
Have you decided how you want to link individual tool release notes? |
|
@ehuss I figured for this release we will we just do the same as previous releases, and I'll write up the format and add more to the |
pietroalbini
added
the
beta-accepted
Co-Authored-By: Josh Stone <cuviper@gmail.com>
pietroalbini
removed
the
beta-nominated
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
|
Hey! This is a ping from triage, we would like to know if you @Mark-Simulacrum could give us a few more minutes to update us from last changes made by @XAMPPRocky . |
|
Modulo @Centril's comment (https://github.com/rust-lang/rust/pull/62653/files#r303208440) I think this is good to go. Edit: would also be good to squash the commits down |
|
Merging as #63147 since GH won't let me push to this branch for some reason (maybe because master?) |
…r=Mark-Simulacrum Updated RELEASES.md for 1.37.0 Squashed rust-lang#62653.
Rendered
r? @Mark-Simulacrum
cc @rust-lang/release