Stabilize cfg(doc) #61351

GuillaumeGomez · 2019-05-30T11:43:15Z

Centril · 2019-05-30T12:00:40Z

src/doc/rustdoc/src/the-doc-attribute.md

+platform-specific code if it *does* receive it.
+
+Because Rustdoc doesn't need to fully compile a crate to binary, it replaces function bodies with
+`loop {}` to prevent having to process more than necessary. This means that any code within a


How does this cope with functions that have -> impl Trait where ! (because of loop {}) does not implement Trait?

cc @QuietMisdreavus

There is currently an exception for -> impl Trait:

rust/src/librustc_interface/util.rs

Lines 668 to 673 in 26451ef

// FIXME: Currently the `everybody_loops` transformation is not applied to:

// * `const fn`, due to issue #43636 that `loop` is not supported for const evaluation. We are

// waiting for miri to fix that.

// * `impl Trait`, due to issue #43869 that functions returning impl Trait cannot be diverging.

// Solving this may require `!` to implement every trait, which relies on the an even more

// ambitious form of the closed RFC #1637. See also [#34511].

This means that #[doc(cfg(...))] doesn't work for those functions yet so I don't think this feature is ready for stabilization yet.

// * `impl Trait`, due to issue #43869 that functions returning impl Trait cannot be diverging. // Solving this may require `!` to implement every trait, which relies on the an even more // ambitious form of the closed RFC #1637. See also [#34511].

This bit seems unlikely from my POV as a T-Lang member... cc @rust-lang/lang if y'all have thoughts...

I'm with @ollie27 here, i had assumed the reason we couldn't stabilize doc(cfg) yet was because the implementation didn't work for all situations.

rust-highfive · 2019-05-30T12:57:12Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:10b45dc0:start=1559216656207704247,finish=1559216743868434663,duration=87660730416
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:08:26] .................................................................................................... 1200/5599
[01:08:29] .................................................................................................... 1300/5599
[01:08:31] .................................................................................................... 1400/5599
[01:08:34] .................................................................................................... 1500/5599
[01:08:37] ...................................F................................................................ 1600/5599
[01:08:44] .................................................................................................... 1800/5599
[01:08:47] .................................................................................................... 1900/5599
[01:08:51] .................................................................................................... 2000/5599
[01:08:54] ..................................................................................i................. 2100/5599
---
[01:11:13] ---- [ui] ui/feature-gates/feature-gate-doc_cfg.rs stdout ----
[01:11:13] 
[01:11:13] error: ui test compiled successfully!
[01:11:13] status: exit code: 0
[01:11:13] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/feature-gates/feature-gate-doc_cfg.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-doc_cfg" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/feature-gate-doc_cfg/auxiliary" "-A" "unused"
[01:11:13] ------------------------------------------
[01:11:13] 
[01:11:13] ------------------------------------------
[01:11:13] stderr:
---
[01:11:13] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:11:13] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:11:13] 
[01:11:13] 
[01:11:13] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:11:13] 
[01:11:13] 
[01:11:13] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:11:13] Build completed unsuccessfully in 0:04:46
[01:11:13] Build completed unsuccessfully in 0:04:46
[01:11:13] make: *** [check] Error 1
[01:11:13] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0817ba86
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May 30 12:57:06 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Manishearth · 2019-05-30T15:09:57Z

src/doc/rustdoc/src/the-doc-attribute.md

+processing early in the compilation process. However, Rustdoc has a trick up its sleeve to handle
+platform-specific code if it *does* receive it.
+
+Because Rustdoc doesn't need to fully compile a crate to binary, it replaces function bodies with


Unsure if this implementation detail needs to be exposed.

I found it interesting so I didn't remove it. :)

GuillaumeGomez · 2019-05-30T21:40:20Z

Forgot to remove a feature test. Updated.

Manishearth · 2019-05-30T21:47:23Z

@bors r+

bors · 2019-05-30T21:47:25Z

📌 Commit cfb63d8beff02c913d80f250887cb6ca8fa53422 has been approved by Manishearth

Centril · 2019-05-30T21:50:58Z

@bors r-

There's an ongoing discussion in #61351 (comment) and a T-rustdoc team member who things this is not ready to stabilize yet.

rust-highfive · 2019-05-30T22:09:31Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1f1ee840:start=1559252560131854340,finish=1559252676774082914,duration=116642228574
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:tidy
tidy check
[00:04:27] * 574 error codes
[00:04:27] * highest error code: E0729
[00:04:30] Expected a gate test for the feature 'doc_cfg'.
[00:04:30] Hint: create a failing test file named 'feature-gate-doc_cfg.rs'
[00:04:30]       in the 'ui' test suite, with its failures due to
[00:04:30]       missing usage of #![feature(doc_cfg)].
[00:04:30] Hint: If you already have such a test and don't want to rename it,
[00:04:30]       you can also add a // gate-test-doc_cfg line to the test file.
[00:04:30] tidy error: Found 1 features without a gate test.
[00:04:32] some tidy checks failed
[00:04:32] 
[00:04:32] 
[00:04:32] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:32] 
[00:04:32] 
[00:04:32] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:32] Build completed unsuccessfully in 0:01:21
[00:04:32] Build completed unsuccessfully in 0:01:21
[00:04:32] Makefile:67: recipe for target 'tidy' failed
[00:04:32] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:33c9ce70
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May 30 21:49:19 UTC 2019
---
travis_time:end:121190f7:start=1559252960000256035,finish=1559252960004647825,duration=4391790
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0dd55b4e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:13cb1c5a
travis_time:start:13cb1c5a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1e3596f6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

QuietMisdreavus · 2019-05-31T18:16:15Z

I'm against stabilizing doc(cfg), because of the following snippet:

#[cfg(any(rustdoc, windows))]
#[doc(cfg(windows))]
pub fn my_handle() -> winapi::shared::ntdef::HANDLE { ... }

We currently don't have a way to handle this code in rustdoc if it's being compiled on non-windows targets, because the winapi crate is totally empty on non-windows targets. This sample will create a type error when rustdoc tries to build it. This sample was discussed at the Rust All-Hands this year, but as far as i know we haven't acted on the discussion that occurred there. In addition, as @ollie27 mentioned, functions returning impl Trait do not receive the benefits of everybody_loops, so the compilation is not perfect in those cases.

...however, i would like to stabilize cfg(rustdoc) separately, since that doesn't have the same ramifications of the rest of doc(cfg). My recommendation would be to either strip out doc(cfg) from this PR and just keep cfg(rustdoc), or close this and open a new one that just stabilizes cfg(rustdoc).

GuillaumeGomez · 2019-06-01T11:04:23Z

I initially wanted to have only cfg(rustdoc) but saw that the two were "linked" so I just stabilized both. I clearly don't mind to only stabilize cfg(rustdoc) (quite the opposite!). I'll update the PR soon.

rust-highfive · 2019-06-01T22:14:30Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1aba78dc:start=1559426211948584947,finish=1559426299470295469,duration=87521710522
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:03:57] tidy error: /checkout/src/test/ui/feature-gates/feature-gate-doc_cfg.rs:1: trailing whitespace
[00:04:02] some tidy checks failed
[00:04:02] 
[00:04:02] 
[00:04:02] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:02] 
[00:04:02] 
[00:04:02] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:02] Build completed unsuccessfully in 0:01:15
---
travis_time:end:04c4dc90:start=1559426551889588206,finish=1559426551894457709,duration=4869503
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0d320960
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:03c8c284
travis_time:start:03c8c284
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:076be766
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rfcbot · 2019-11-13T17:35:23Z

🔔 This is now entering its final comment period, as per the review above. 🔔

bors · 2019-11-14T02:33:56Z

☔ The latest upstream changes (presumably #66211) made this pull request unmergeable. Please resolve the merge conflicts.

rfcbot · 2019-11-23T17:44:06Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

GuillaumeGomez · 2019-11-23T19:13:37Z

@bors: r=QuietMisdreavus

bors · 2019-11-23T19:13:39Z

📌 Commit 0d7a7b5 has been approved by QuietMisdreavus

…c, r=QuietMisdreavus Stabilize cfg(doc) cc rust-lang#43781.

@ghost

Rollup of 5 pull requests Successful merges: - #61351 (Stabilize cfg(doc)) - #66539 (Point at type in `let` assignment on type errors) - #66655 (rustdoc: Mark `--extern-private` as unstable) - #66657 (rustdoc: Don't panic when failing to write .lock file) - #66673 (Move def collector from `rustc` to `rustc_resolve`) Failed merges: r? @ghost

bors · 2019-11-24T01:39:05Z

☔ The latest upstream changes (presumably #66680) made this pull request unmergeable. Please resolve the merge conflicts.

`cfg(doc)` has been stabilized in rust-lang/rust#61351.

Version 1.41.0 (2020-01-30) =========================== Language -------- - [You can now pass type parameters to foreign items when implementing traits.][65879] E.g. You can now write `impl<T> From<Foo> for Vec<T> {}`. - [You can now arbitrarily nest receiver types in the `self` position.][64325] E.g. you can now write `fn foo(self: Box<Box<Self>>) {}`. Previously only `Self`, `&Self`, `&mut Self`, `Arc<Self>`, `Rc<Self>`, and `Box<Self>` were allowed. - [You can now use any valid identifier in a `format_args` macro.][66847] Previously identifiers starting with an underscore were not allowed. - [Visibility modifiers (e.g. `pub`) are now syntactically allowed on trait items and enum variants.][66183] These are still rejected semantically, but can be seen and parsed by procedural macros and conditional compilation. Compiler -------- - [Rustc will now warn if you have unused loop `'label`s.][66325] - [Removed support for the `i686-unknown-dragonfly` target.][67255] - [Added tier 3 support\* for the `riscv64gc-unknown-linux-gnu` target.][66661] - [You can now pass an arguments file passing the `@path` syntax to rustc.][66172] Note that the format differs somewhat from what is found in other tooling; please see [the documentation][argfile-docs] for more information. - [You can now provide `--extern` flag without a path, indicating that it is available from the search path or specified with an `-L` flag.][64882] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. [argfile-docs]: https://doc.rust-lang.org/nightly/rustc/command-line-arguments.html#path-load-command-line-flags-from-a-path Libraries --------- - [The `core::panic` module is now stable.][66771] It was already stable through `std`. - [`NonZero*` numerics now implement `From<NonZero*>` if it's a smaller integer width.][66277] E.g. `NonZeroU16` now implements `From<NonZeroU8>`. - [`MaybeUninit<T>` now implements `fmt::Debug`.][65013] Stabilized APIs --------------- - [`Result::map_or`] - [`Result::map_or_else`] - [`std::rc::Weak::weak_count`] - [`std::rc::Weak::strong_count`] - [`std::sync::Weak::weak_count`] - [`std::sync::Weak::strong_count`] Cargo ----- - [Cargo will now document all the private items for binary crates by default.][cargo/7593] - [`cargo-install` will now reinstall the package if it detects that it is out of date.][cargo/7560] - [Cargo.lock now uses a more git friendly format that should help to reduce merge conflicts.][cargo/7579] - [You can now override specific dependencies's build settings][cargo/7591] E.g. `[profile.dev.overrides.image] opt-level = 2` sets the `image` crate's optimisation level to `2` for debug builds. You can also use `[profile.<profile>.build_overrides]` to override build scripts and their dependencies. Misc ---- - [You can now specify `edition` in documentation code blocks to compile the block for that edition.][66238] E.g. `edition2018` tells rustdoc that the code sample should be compiled the 2018 edition of Rust. - [You can now provide custom themes to rustdoc with `--theme`, and check the current theme with `--check-theme`.][54733] - [You can use `#[cfg(doc)]` to compile an item when building documentation.][61351] Compatibility Notes ------------------- - [As previously announced 1.41.0 will be the last tier 1 release for 32-bit Apple targets.][apple-32bit-drop] This means that the source code is still available to build, but the targets are no longer being tested and release binaries for those platforms will no longer be distributed by the Rust project. Please refer to the linked blog post for more information. [54733]: rust-lang/rust#54733 [61351]: rust-lang/rust#61351 [67255]: rust-lang/rust#67255 [66661]: rust-lang/rust#66661 [66771]: rust-lang/rust#66771 [66847]: rust-lang/rust#66847 [66238]: rust-lang/rust#66238 [66277]: rust-lang/rust#66277 [66325]: rust-lang/rust#66325 [66172]: rust-lang/rust#66172 [66183]: rust-lang/rust#66183 [65879]: rust-lang/rust#65879 [65013]: rust-lang/rust#65013 [64882]: rust-lang/rust#64882 [64325]: rust-lang/rust#64325 [cargo/7560]: rust-lang/cargo#7560 [cargo/7579]: rust-lang/cargo#7579 [cargo/7591]: rust-lang/cargo#7591 [cargo/7593]: rust-lang/cargo#7593 [`Result::map_or_else`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or_else [`Result::map_or`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or [`std::rc::Weak::weak_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.weak_count [`std::rc::Weak::strong_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.strong_count [`std::sync::Weak::weak_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.weak_count [`std::sync::Weak::strong_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.strong_count [apple-32bit-drop]: https://blog.rust-lang.org/2020/01/03/reducing-support-for-32-bit-apple-targets.html

`rustdoc` is now just `doc` and no longer requires unstable features. This raises the MSRV for building cargo-examples's documentationto 1.41.0. See rust-lang/rust#61351 Fixes #101

rust-highfive assigned Manishearth May 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019

Centril reviewed May 30, 2019

View reviewed changes

Centril added relnotes Marks issues that should be documented in the release notes of the next release. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 30, 2019

Centril added this to the 1.37 milestone May 30, 2019

petrochenkov self-assigned this May 30, 2019

Manishearth reviewed May 30, 2019

View reviewed changes

Manishearth approved these changes May 30, 2019

View reviewed changes

GuillaumeGomez force-pushed the stabilize-cfg-rustdoc branch from 117c244 to cfb63d8 Compare May 30, 2019 21:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2019

petrochenkov removed their assignment May 31, 2019

kennytm changed the title ~~Stabilize cfg(doc(...)) and cfg(rustdoc)~~ Stabilize doc(cfg(...)) and cfg(rustdoc) May 31, 2019

kennytm added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label May 31, 2019

GuillaumeGomez force-pushed the stabilize-cfg-rustdoc branch 4 times, most recently from a33e4e4 to 135e5f3 Compare June 1, 2019 21:54

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Nov 13, 2019

GuillaumeGomez and others added 3 commits November 21, 2019 15:37

Stabilize cfg rustdoc

086c8d3

Rename the cfg attribute from rustdoc to doc

a056bf9

move cfg(doc) docs into a separate page

0d7a7b5

GuillaumeGomez force-pushed the stabilize-cfg-rustdoc branch from c8985de to 0d7a7b5 Compare November 21, 2019 14:38

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 23, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2019

Centril added a commit to Centril/rust that referenced this pull request Nov 23, 2019

Rollup merge of rust-lang#61351 - GuillaumeGomez:stabilize-cfg-rustdo…

6618af2

…c, r=QuietMisdreavus Stabilize cfg(doc) cc rust-lang#43781.

Centril mentioned this pull request Nov 23, 2019

Rollup of 5 pull requests #66680

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2019

bors merged commit 0d7a7b5 into rust-lang:master Nov 24, 2019

GuillaumeGomez deleted the stabilize-cfg-rustdoc branch November 24, 2019 11:23

yvt added a commit to yvt/Stella2 that referenced this pull request Jan 1, 2020

Replace cfg(rustdoc) with cfg(doc)

47b6dc1

`cfg(doc)` has been stabilized in rust-lang/rust#61351.

asomers mentioned this pull request Feb 21, 2020

Fix building cargo-examples after stabilization of #cfg(doc) asomers/mockall#103

Merged

dtolnay mentioned this pull request Oct 7, 2020

Remove doc = $ident attributes dtolnay/readonly#6

Merged

dtolnay mentioned this pull request Mar 5, 2023

Update for stable cfg(doc) dtolnay/case-studies#18

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize cfg(doc) #61351

Stabilize cfg(doc) #61351

GuillaumeGomez commented May 30, 2019 •

edited by Mark-Simulacrum

Loading

Centril May 30, 2019 •

edited

Loading

GuillaumeGomez May 30, 2019

ollie27 May 30, 2019

Centril May 30, 2019

QuietMisdreavus May 31, 2019

rust-highfive commented May 30, 2019

Manishearth May 30, 2019

GuillaumeGomez May 30, 2019

GuillaumeGomez commented May 30, 2019

Manishearth commented May 30, 2019

bors commented May 30, 2019

Centril commented May 30, 2019

rust-highfive commented May 30, 2019

QuietMisdreavus commented May 31, 2019

GuillaumeGomez commented Jun 1, 2019

rust-highfive commented Jun 1, 2019

rfcbot commented Nov 13, 2019

bors commented Nov 14, 2019

rfcbot commented Nov 23, 2019

GuillaumeGomez commented Nov 23, 2019

bors commented Nov 23, 2019

bors commented Nov 24, 2019

	// FIXME: Currently the `everybody_loops` transformation is not applied to:
	// * `const fn`, due to issue #43636 that `loop` is not supported for const evaluation. We are
	// waiting for miri to fix that.
	// * `impl Trait`, due to issue #43869 that functions returning impl Trait cannot be diverging.
	// Solving this may require `!` to implement every trait, which relies on the an even more
	// ambitious form of the closed RFC #1637. See also [#34511].

Stabilize cfg(doc) #61351

Stabilize cfg(doc) #61351

Conversation

GuillaumeGomez commented May 30, 2019 • edited by Mark-Simulacrum Loading

Centril May 30, 2019 • edited Loading

Choose a reason for hiding this comment

GuillaumeGomez May 30, 2019

Choose a reason for hiding this comment

ollie27 May 30, 2019

Choose a reason for hiding this comment

Centril May 30, 2019

Choose a reason for hiding this comment

QuietMisdreavus May 31, 2019

Choose a reason for hiding this comment

rust-highfive commented May 30, 2019

Manishearth May 30, 2019

Choose a reason for hiding this comment

GuillaumeGomez May 30, 2019

Choose a reason for hiding this comment

GuillaumeGomez commented May 30, 2019

Manishearth commented May 30, 2019

bors commented May 30, 2019

Centril commented May 30, 2019

rust-highfive commented May 30, 2019

QuietMisdreavus commented May 31, 2019

GuillaumeGomez commented Jun 1, 2019

rust-highfive commented Jun 1, 2019

rfcbot commented Nov 13, 2019

bors commented Nov 14, 2019

rfcbot commented Nov 23, 2019

GuillaumeGomez commented Nov 23, 2019

bors commented Nov 23, 2019

bors commented Nov 24, 2019

GuillaumeGomez commented May 30, 2019 •

edited by Mark-Simulacrum

Loading

Centril May 30, 2019 •

edited

Loading