Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo_examples isn't being built with the nightly-docs flag #101

Closed
asomers opened this issue Feb 15, 2020 · 0 comments · Fixed by #103
Closed

cargo_examples isn't being built with the nightly-docs flag #101

asomers opened this issue Feb 15, 2020 · 0 comments · Fixed by #103
Assignees
@asomers
Labels
bug Something isn't working

Comments

@asomers
Copy link
Owner

asomers commented Feb 15, 2020

Somewhere between +nightly-2019-05-20 and +nightly-2019-11-25 Cargo changed its behavior. It's now no longer building docs with the nightly-docs feature flag on. As a result, the cargo_examples crate is useless.
@asomers asomers added the bug Something isn't working label Feb 15, 2020
@asomers asomers self-assigned this Feb 15, 2020
asomers added a commit that referenced this issue Feb 21, 2020
@asomers
Fix building cargo-examples after stabilization of #cfg(doc)
1e1e925 
`rustdoc` is now just `doc` and no longer requires unstable features.
This raises the MSRV for building cargo-examples's documentationto
1.41.0.
See rust-lang/rust#61351

Fixes #101
@asomers asomers mentioned this issue Feb 21, 2020
Merged
asomers added a commit that referenced this issue Feb 21, 2020
@asomers
Fix building cargo-examples after stabilization of #cfg(doc)
356f968 
`rustdoc` is now just `doc` and no longer requires unstable features.
This raises the MSRV for building cargo-examples's documentationto
1.41.0.
See rust-lang/rust#61351

Fixes #101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asomers asomers

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix building cargo-examples after stabilization of #cfg(doc) asomers/mockall
1 participant
@asomers