Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move arbitrary self types's tests into ui/self #60950

Merged
merged 2 commits into from
May 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// run-pass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't move run-pass tests into ui directory, or move and make them compile-pass if they don't really require running.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petrochenkov We're trying to retire the run-pass directory altogether; It's pretty bad organization to have some tests for some feature in test/run-pass/foo and some in test/ui/foo. But yeah, make it compile-pass if it doesn't need to be actually run.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Centril

We're trying to retire the run-pass directory altogether

This was tried, but reverted, see #54530.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an unfortunate move to me. Something should be done about the current chaos in the src/test directory. One shouldn't have to look in different places for tests pertaining to one specific interest. That is especially annoying when writing stabilization reports and whatnot.

For now, let's move ahead with moving these specific tests.

#![feature(arbitrary_self_types, unsize, coerce_unsized, dispatch_from_dyn)]
#![feature(rustc_attrs)]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// run-pass
#![feature(arbitrary_self_types)]
#![feature(rustc_attrs)]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// run-pass
// compile-pass
Copy link
Member Author

@taiki-e taiki-e May 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed run-pass tests with empty main function to compile-pass.

#![allow(dead_code)]
// Test to make sure that explicit self params work inside closures

Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// run-pass
// compile-pass

#![feature(untagged_unions)]

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// run-pass
// compile-pass
#![allow(dead_code)]
// pretty-expanded FIXME #23616

Expand Down