Move arbitrary self types's tests into ui/self #60950
Conversation
rust-highfive
added
the
S-waiting-on-review
taiki-e
force-pushed
the
arbitrary_self_types-tests
branch
from
a22253a
to
b53d839
Compare
| @@ -1,3 +1,4 @@ | |||
| // run-pass | |||
There was a problem hiding this comment.
Please don't move run-pass tests into ui directory, or move and make them compile-pass if they don't really require running.
There was a problem hiding this comment.
@petrochenkov We're trying to retire the run-pass directory altogether; It's pretty bad organization to have some tests for some feature in test/run-pass/foo and some in test/ui/foo. But yeah, make it compile-pass if it doesn't need to be actually run.
There was a problem hiding this comment.
Seems like an unfortunate move to me. Something should be done about the current chaos in the src/test directory. One shouldn't have to look in different places for tests pertaining to one specific interest. That is especially annoying when writing stabilization reports and whatnot.
For now, let's move ahead with moving these specific tests.
|
@taiki-e Can you please move the other files in the |
|
@Centril How should I handle files of the same name? EDIT: I renamed |
| @@ -1,4 +1,4 @@ | |||
| // run-pass | |||
| // compile-pass | |||
There was a problem hiding this comment.
Changed run-pass tests with empty main function to compile-pass.
|
@bors r+ rollup |
|
📌 Commit 3e73ca6 has been approved by |
bors
added
S-waiting-on-bors
… r=Centril Move arbitrary self types's tests into ui/self rust-lang#60944 (comment) r? @Centril
Move arbitrary self types's tests into ui/self #60944 (comment) r? @Centril
|
☀️ Test successful - checks-travis, status-appveyor |
#60944 (comment)
r? @Centril