Allow closure to unsafe fn coercion #59580

taiki-e · 2019-03-31T11:42:48Z

Closes #57883

rust-highfive · 2019-03-31T11:42:58Z

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

Centril

👍

src/librustc/ty/context.rs

src/librustc/mir/mod.rs

src/librustc_typeck/check/coercion.rs

src/test/run-pass/typeck-closure-to-unsafe-fn-ptr.rs

oli-obk · 2019-03-31T16:10:37Z

Impl lgtm. Issue suggests that this doesn't need an FCP.

@bors r+

I opened an issue (#59588) talking about my unhappiness with the fact that this PR had to touch three enums. Note that this is absolutely not this PR's fault, but just the way our datastructes are laid out.

bors · 2019-03-31T16:10:38Z

📌 Commit 07021e0 has been approved by oli-obk

Allow closure to unsafe fn coercion Closes rust-lang#57883

@ghost

Rollup of 7 pull requests Successful merges: - #58805 (Lint for redundant imports) - #59506 (Use platform dependent mcount function) - #59519 (rustc_target: factor out common fields of non-Single Variants.) - #59580 (Allow closure to unsafe fn coercion) - #59581 (Stabilize refcell_replace_swap feature) - #59583 (match match match match match) - #59587 (Remove #[doc(hidden)] from Error::type_id) Failed merges: r? @ghost

Version 1.35.0 (2019-05-23) ========================== Language -------- - [`FnOnce`, `FnMut`, and the `Fn` traits are now implemented for `Box<FnOnce>`, `Box<FnMut>`, and `Box<Fn>` respectively.][59500] - [You can now coerce closures into unsafe function pointers.][59580] e.g. ```rust unsafe fn call_unsafe(func: unsafe fn()) { func() } pub fn main() { unsafe { call_unsafe(|| {}); } } ``` Compiler -------- - [Added the `armv6-unknown-freebsd-gnueabihf` and `armv7-unknown-freebsd-gnueabihf` targets.][58080] - [Added the `wasm32-unknown-wasi` target.][59464] Libraries --------- - [`Thread` will now show its ID in `Debug` output.][59460] - [`StdinLock`, `StdoutLock`, and `StderrLock` now implement `AsRawFd`.][59512] - [`alloc::System` now implements `Default`.][59451] - [Expanded `Debug` output (`{:#?}`) for structs now has a trailing comma on the last field.][59076] - [`char::{ToLowercase, ToUppercase}` now implement `ExactSizeIterator`.][58778] - [All `NonZero` numeric types now implement `FromStr`.][58717] - [Removed the `Read` trait bounds on the `BufReader::{get_ref, get_mut, into_inner}` methods.][58423] - [You can now call the `dbg!` macro without any parameters to print the file and line where it is called.][57847] - [In place ASCII case conversions are now up to 4× faster.][59283] e.g. `str::make_ascii_lowercase` - [`hash_map::{OccupiedEntry, VacantEntry}` now implement `Sync` and `Send`.][58369] Stabilized APIs --------------- - [`f32::copysign`] - [`f64::copysign`] - [`RefCell::replace_with`] - [`RefCell::map_split`] - [`ptr::hash`] - [`Range::contains`] - [`RangeFrom::contains`] - [`RangeTo::contains`] - [`RangeInclusive::contains`] - [`RangeToInclusive::contains`] - [`Option::copied`] Cargo ----- - [You can now set `cargo:rustc-cdylib-link-arg` at build time to pass custom linker arguments when building a `cdylib`.][cargo/6298] Its usage is highly platform specific. Misc ---- - [The Rust toolchain is now available natively for musl based distros.][58575] [59460]: rust-lang/rust#59460 [59464]: rust-lang/rust#59464 [59500]: rust-lang/rust#59500 [59512]: rust-lang/rust#59512 [59580]: rust-lang/rust#59580 [59283]: rust-lang/rust#59283 [59451]: rust-lang/rust#59451 [59076]: rust-lang/rust#59076 [58778]: rust-lang/rust#58778 [58717]: rust-lang/rust#58717 [58369]: rust-lang/rust#58369 [58423]: rust-lang/rust#58423 [58080]: rust-lang/rust#58080 [57847]: rust-lang/rust#57847 [58575]: rust-lang/rust#58575 [cargo/6298]: rust-lang/cargo#6298 [`f32::copysign`]: https://doc.rust-lang.org/stable/std/primitive.f32.html#method.copysign [`f64::copysign`]: https://doc.rust-lang.org/stable/std/primitive.f64.html#method.copysign [`RefCell::replace_with`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.replace_with [`RefCell::map_split`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.map_split [`ptr::hash`]: https://doc.rust-lang.org/stable/std/ptr/fn.hash.html [`Range::contains`]: https://doc.rust-lang.org/std/ops/struct.Range.html#method.contains [`RangeFrom::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeFrom.html#method.contains [`RangeTo::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeTo.html#method.contains [`RangeInclusive::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeInclusive.html#method.contains [`RangeToInclusive::contains`]: https://doc.rust-lang.org/std/ops/struct.RangeToInclusive.html#method.contains [`Option::copied`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.copied

rust-highfive assigned oli-obk Mar 31, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2019

Centril suggested changes Mar 31, 2019

View reviewed changes

src/librustc/ty/context.rs Show resolved Hide resolved

src/librustc/mir/mod.rs Show resolved Hide resolved

src/librustc_typeck/check/coercion.rs Show resolved Hide resolved

src/test/run-pass/typeck-closure-to-unsafe-fn-ptr.rs Show resolved Hide resolved

Centril added T-lang Relevant to the language team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Mar 31, 2019

Centril added this to the 1.35 milestone Mar 31, 2019

Allow closure to unsafe fn coercion

07021e0

taiki-e force-pushed the coerce-closure branch from be0a788 to 07021e0 Compare March 31, 2019 15:01

Centril approved these changes Mar 31, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2019

Centril added a commit to Centril/rust that referenced this pull request Mar 31, 2019

Rollup merge of rust-lang#59580 - taiki-e:coerce-closure, r=oli-obk

1909a03

Allow closure to unsafe fn coercion Closes rust-lang#57883

Centril mentioned this pull request Mar 31, 2019

Rollup of 7 pull requests #59590

Merged

bors merged commit 07021e0 into rust-lang:master Mar 31, 2019

taiki-e deleted the coerce-closure branch March 31, 2019 20:30

jplatte mentioned this pull request Jun 4, 2019

Allow closure to extern fn pointer coercion #61528

Closed

ldm0 mentioned this pull request May 15, 2020

Drive-by mention unsafe fn closure coercion rust-lang/reference#802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow closure to unsafe fn coercion #59580

Allow closure to unsafe fn coercion #59580

taiki-e commented Mar 31, 2019

rust-highfive commented Mar 31, 2019

Centril left a comment

oli-obk commented Mar 31, 2019

bors commented Mar 31, 2019

Allow closure to unsafe fn coercion #59580

Allow closure to unsafe fn coercion #59580

Conversation

taiki-e commented Mar 31, 2019

rust-highfive commented Mar 31, 2019

Centril left a comment

Choose a reason for hiding this comment

oli-obk commented Mar 31, 2019

bors commented Mar 31, 2019