Remove images' url to make it work even without internet connection #58185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Looks great to me. This would mean the Debian packages don't need to sed away these URIs in the output anymore. cc @infinity0 |
|
@bors r+ |
|
📌 Commit 3a9696abefd168ad88bb3e6548e58d39f6a1d507 has been approved by |
bors
added
S-waiting-on-bors
|
awesome thanks! |
|
@bors rollup |
bors
added a commit
that referenced
this pull request
Feb 7, 2019
Rollup of 23 pull requests Successful merges: - #58118 (Transition libtest to 2018 edition) - #58119 (libproc_macro => 2018) - #58123 (Avoid some bounds checks in binary_heap::{PeekMut,Hole}) - #58124 (libsyntax_pos => 2018) - #58133 (libsyntax_ext => 2018) - #58136 (Improve error message and docs for non-UTF-8 bytes in stdio on Windows) - #58156 (update submodule: rust-installer from 27dec6c to ccdc47b) - #58192 (Do not ICE in codegen when using a extern_type static) - #58193 (Move librustc to 2018) - #58210 (Make an assert debug-only in `find_constraint_paths_between_regions`.) - #58217 (librustc_tsan => 2018) - #58218 (librustc_msan => 2018) - #58219 (librustc_asan => 2018) - #58220 (libprofiler_builtins => 2018) - #58223 (librustc_lsan => 2018) - #58225 (librustc_fs_util => 2018) - #58228 (librustc_plugin => 2018) - #58236 (librustc_resolve => 2018) - #58237 (Fix broken grammar in iter::from_fn() docs) - #58239 (librustc_apfloat => 2018) - #58240 (librustc_errors => 2018) - #58241 (librustc_llvm => 2018) - #58242 (Document the one TyKind that isn't documented) Failed merges: - #58185 (Remove images' url to make it work even without internet connection) r? @ghost
|
☔ The latest upstream changes (presumably #58254) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
images-url
branch
from
3a9696a
to
8b886e0
Compare
|
Rebased. |
GuillaumeGomez
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8b886e0 has been approved by |
bors
added
S-waiting-on-bors
|
By the way @GuillaumeGomez, does this remove the logo entirely or is there a copy of it shipped together with the generated docs? |
|
If the |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 7, 2019
…apin Remove images' url to make it work even without internet connection Needed for local std docs mainly. cc @SimonSapin r? @QuietMisdreavus
bors
added a commit
that referenced
this pull request
Feb 7, 2019
Rollup of 11 pull requests Successful merges: - #57504 (Re-enable history api on file:// protocol) - #57848 (Generate a documentation page for core::mem::transmute.) - #57884 (Update minifier version) - #57954 (rustdoc: remove blank unstable spans) - #58028 (Fix image link in the settings menu) - #58033 (rustdoc: wrap stability tags in colored spans) - #58086 ([rustdoc] Improve file list display) - #58143 (Sort elements in the sidebar) - #58146 (Prevent automatic collapse of methods impl blocks) - #58150 (Don't apply impl block collapse rules to trait impls) - #58185 (Remove images' url to make it work even without internet connection) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for local std docs mainly.
cc @SimonSapin
r? @QuietMisdreavus