Re-enable history api on file:// protocol

[GuillaumeGomez]

Fixes #57135.

I tested locally on chrome (since it was the browser having issues with history management on file:// protocol) and it worked fine so I guess we can re-enable it.

r? @QuietMisdreavus

[ecstatic-morse]

Using history.pushState on a page loaded from file:// throws a SecurityError in Firefox 64, so I don't think you should unconditionally enable this.

As far as I can tell, it looks like history.pushState on a page loaded from file:// throws a SecurityError in Firefox 64 if the pages have different origin. Since opening the search window just adds a query parameter, the calls pushState should be fine for most modern browsers, but you might want to add a comment to this effect.

[steveklabnik]

Yes, we have to test more than just Chrome :)

…

On Thu, Jan 10, 2019 at 6:32 PM ecstatic-morse ***@***.***> wrote: Using history.pushState on a page loaded from file:// throws a SecurityError in Firefox 64, so I don't think you should unconditionally enable this. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#57504 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABsik8HNtKAhpsPt8w9pGZq-f8N8xb6ks5vB816gaJpZM4Z6fNb> .

[GuillaumeGomez]

The problem was supposed to be only on chrome. My firefox worked correctly though.

[QuietMisdreavus]

As far as I can tell, it looks like history.pushState on a page loaded from file:// throws a SecurityError in Firefox 64 if the pages have different origin. Since opening the search window just adds a query parameter, the calls pushState should be fine for most modern browsers, but you might want to add a comment to this effect.

This seems to make it okay? I think we only use the history API when loading up the search results, so it may work out.

[GuillaumeGomez]

Normally yes.

[QuietMisdreavus]

I double-checked main.js to make sure we only used the history API (or at least, only this detection) when modifying the query string or hash of the URL, and not the file. Because of that, i'm okay merging this.

@bors r+ rollup

[bors]

📌 Commit 830b3b8 has been approved by QuietMisdreavus