Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: Make "empty import canaries" invisible from other crates #56117

Merged
merged 1 commit into from
Nov 21, 2018
Merged

resolve: Make "empty import canaries" invisible from other crates #56117

merged 1 commit into from
Nov 21, 2018

Conversation

petrochenkov
Copy link
Contributor

Empty imports use prefix::{}; are desugared into use prefix::{self as _}; to make sure the prefix is checked for privacy/stability/etc.
This caused issues in cross-crate scenarios because gensyms are lost in crate metadata (the _ is a gensym).

Fixes #55811

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2018
@petrochenkov
Copy link
Contributor Author

This is a fix for stable-to-beta regression, so I'm going to beta-nominate if it's not too late.

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned oli-obk Nov 21, 2018
@petrochenkov petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 21, 2018
@petrochenkov petrochenkov added this to the Rust 2018 Release milestone Nov 21, 2018
@petrochenkov petrochenkov mentioned this pull request Nov 21, 2018
Closed
@eddyb
Copy link
Member

eddyb commented Nov 21, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Nov 21, 2018

📌 Commit 1e4cf74 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2018
@alexcrichton
Copy link
Member

@bors: p=1

@bors
Copy link
Contributor

bors commented Nov 21, 2018

⌛ Testing commit 1e4cf74 with merge 01deeb44d6df79efed934b4d7a9e002a3673e9d1...

@bors
Copy link
Contributor

bors commented Nov 21, 2018

💔 Test failed - status-travis

@rust-highfive
Copy link
Collaborator

The job asmjs of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2018
@petrochenkov
Copy link
Contributor Author

Seems like Travis job just died in the middle of LLVM build.
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2018
@bors
Copy link
Contributor

bors commented Nov 21, 2018

⌛ Testing commit 1e4cf74 with merge ee7bb94...

bors added a commit that referenced this pull request Nov 21, 2018
@bors
Auto merge of #56117 - petrochenkov:iempty, r=eddyb
ee7bb94 
resolve: Make "empty import canaries" invisible from other crates

Empty imports `use prefix::{};` are desugared into `use prefix::{self as _};` to make sure the prefix is checked for privacy/stability/etc.
This caused issues in cross-crate scenarios because gensyms are lost in crate metadata (the `_` is a gensym).

Fixes #55811
@bors
Copy link
Contributor

bors commented Nov 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing ee7bb94 to master...

@bors bors merged commit 1e4cf74 into rust-lang:master Nov 21, 2018
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 21, 2018
@pietroalbini pietroalbini mentioned this pull request Nov 22, 2018
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 23, 2018
bors added a commit that referenced this pull request Nov 23, 2018
@bors
Auto merge of #56174 - pietroalbini:beta-rollup, r=alexcrichton
1c16fa4 
[beta] Rollup backports

* #56163: [master] Backport 1.30.1 release notes
* #56147: resolve: Fix some asserts in import validation
* #56118: Update books for Rust 2018
* #56117: resolve: Make "empty import canaries" invisible from other crates
* #56065: Replace the ICEing on const fn loops with an error
* #56143: Issue 56128 segment id ice nightly
* #56134: Fix clippy documentation links (first in #56156)

r? @ghost
@petrochenkov petrochenkov deleted the iempty branch June 5, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
Rust 2018 Release
Development

Successfully merging this pull request may close these issues.

Name _ defined multiple times
6 participants
@petrochenkov @rust-highfive @eddyb @bors @alexcrichton @oli-obk