Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name _ defined multiple times #55811

Closed
Mark-Simulacrum opened this issue Nov 9, 2018 · 1 comment · Fixed by #56117
Closed

Name _ defined multiple times #55811

Mark-Simulacrum opened this issue Nov 9, 2018 · 1 comment · Fixed by #56117
Assignees
@petrochenkov
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.31-1/beta-2018-10-30/reg/type_level_examples-0.0.22/log.txt, https://crates.io/crates/type_level_examples/0.0.22

error[E0428]: the name `_` is defined multiple times
Nov 02 01:29:54.935 INFO kablam!   |
Nov 02 01:29:54.935 INFO kablam!   = note: `_` must be defined only once in the type namespace of this module

This appears to ICE on nightly so maybe that's the underlying cause?

cc @petrochenkov
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Nov 9, 2018
@petrochenkov petrochenkov self-assigned this Nov 9, 2018
@nagisa nagisa added the P-high High priority label Nov 15, 2018
@alexcrichton alexcrichton mentioned this issue Nov 19, 2018
Closed
@petrochenkov petrochenkov mentioned this issue Nov 21, 2018
Merged
@petrochenkov
Copy link
Contributor

Fixed in #56117

bors added a commit that referenced this issue Nov 21, 2018
@bors
Auto merge of #56117 - petrochenkov:iempty, r=eddyb
ee7bb94 
resolve: Make "empty import canaries" invisible from other crates

Empty imports `use prefix::{};` are desugared into `use prefix::{self as _};` to make sure the prefix is checked for privacy/stability/etc.
This caused issues in cross-crate scenarios because gensyms are lost in crate metadata (the `_` is a gensym).

Fixes #55811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petrochenkov petrochenkov

Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve: Make "empty import canaries" invisible from other crates petrochenkov/rust
3 participants
@nagisa @Mark-Simulacrum @petrochenkov