rustdoc: Show purity #5536

sanxiyn · 2013-03-25T06:05:44Z

Fix #3804.

thestinger · 2013-03-25T06:09:58Z

Is purity still around? I thought @pcwalton succeeded in removing it.

huonw · 2013-03-25T06:22:52Z

I think the unsafe and extern "purities" are still around.

thestinger · 2013-03-25T06:24:20Z

@dbaupp: Ah, that makes sense.

Fix #3804.

Fix the bugs of `manual_memcpy`, simplify the suggestion and refactor it While I’m working on the long procrastinated work to expand `manual_memcpy`(rust-lang#1670), I found a few minor bugs and probably unidiomatic or old coding style. There is a brief explanation of changes to the behaviour this PR will make below. And, I have a questoin: do I need to add tests for the first and second fixed bugs? I thought it might be too rare cases to include the tests for those. I added for the last one though. * Bug fix * It negates resulted offsets (`src/dst_offset`) when `offset` is subtraction by 0. This PR will remove any subtraction by 0 as a part of minification. ```rust for i in 0..5 { dst[i - 0] = src[i]; } ``` ```diff warning: it looks like you're manually copying between slices --> src/main.rs:2:14 | LL | for i in 0..5 { - | ^^^^ help: try replacing the loop by: `dst[..-5].clone_from_slice(&src[..5])` + | ^^^^ help: try replacing the loop by: `dst[..5].clone_from_slice(&src[..5])` | ``` * It prints `RangeTo` or `RangeFull` when both of `end` and `offset` are 0, which have different meaning. This PR will print 0. I could reject the cases `end` is 0, but I thought I won’t catch other cases `reverse_range_loop` will trigger, and it’s over to catch every such cases. ```rust for i in 0..0 { dst[i] = src[i]; } ``` ```diff warning: it looks like you're manually copying between slices --> src/main.rs:2:14 | LL | for i in 0..0 { - | ^^^^ help: try replacing the loop by: `dst.clone_from_slice(&src[..])` + | ^^^^ help: try replacing the loop by: `dst[..0].clone_from_slice(&src[..0])` | ``` * it prints four dots when `end` is `None`. This PR will ignore any `for` loops without `end` because a `for` loop that takes `RangeFrom` as its argument and contains indexing without the statements or the expressions that end loops such as `break` will definitely panic, and `manual_memcpy` should ignore the loops with such control flow. ```rust fn manual_copy(src: &[u32], dst: &mut [u32]) { for i in 0.. { dst[i] = src[i]; } } ``` ```diff -warning: it looks like you're manually copying between slices - --> src/main.rs:2:14 - | -LL | for i in 0.. { - | ^^^ help: try replacing the loop by: `dst[....].clone_from_slice(&src[....])` - | ``` * Simplification of the suggestion * It prints 0 when `start` or `end` and `offset` are same (from rust-lang#3323). This PR will use `RangeTo` changelog: fixed the bugs of `manual_memcpy` and also simplify the suggestion.

Fixes 5533, 5568, 5907 Prevent `format_code_in_doc_comments=true` from affecting how non-doc comments are formatted. --------- Co-authored-by: Yacin Tmimi <yacintmimi@gmail.com>

rustdoc: Show purity

585c572

bors added a commit that referenced this pull request Mar 26, 2013

auto merge of #5536 : sanxiyn/rust/doc-purity, r=brson

5591d34

Fix #3804.

bors closed this Mar 26, 2013

bors merged commit 585c572 into rust-lang:incoming Mar 26, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: Show purity #5536

rustdoc: Show purity #5536

sanxiyn commented Mar 25, 2013

thestinger commented Mar 25, 2013

huonw commented Mar 25, 2013

thestinger commented Mar 25, 2013

rustdoc: Show purity #5536

rustdoc: Show purity #5536

Conversation

sanxiyn commented Mar 25, 2013

thestinger commented Mar 25, 2013

huonw commented Mar 25, 2013

thestinger commented Mar 25, 2013