Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe-ness not visible in library reference doc #3804

Closed
dckc opened this issue Oct 18, 2012 · 3 comments
Closed

unsafe-ness not visible in library reference doc #3804

dckc opened this issue Oct 18, 2012 · 3 comments
Assignees
@alexcrichton
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
0.6

Comments

@dckc
Copy link
Contributor

dckc commented Oct 18, 2012

local_data.rs line 55 declares this function unsafe:

pub unsafe fn local_data_get<T: Owned>(

but the docs for task_local_data doesn't show the unsafe keyword:

fn local_data_get<T: Owned>(key: LocalDataKey<T>) -> Option<@T>

Is this a rustdoc limitation?
@brson
Copy link
Contributor

brson commented Oct 22, 2012

Also pure.

@brson brson mentioned this issue Mar 25, 2013
Closed
@sanxiyn sanxiyn mentioned this issue Mar 25, 2013
Merged
bors added a commit that referenced this issue Mar 26, 2013
@bors
auto merge of #5536 : sanxiyn/rust/doc-purity, r=brson
5591d34 
Fix #3804.
@sanxiyn sanxiyn closed this as completed Mar 26, 2013
@dckc
Copy link
Contributor Author

dckc commented Sep 24, 2013

I saw the news about rustdoc_ng in "This week in Rust", and now I see this was closed 6 months ago, but it doesn't look fixed to me:

https://github.com/mozilla/rust/blob/master/src/libstd/local_data.rs#L92 says unsafe
http://static.rust-lang.org/doc/master/std/local_data/fn.get_local_map.html doesn't

@alexcrichton
Copy link
Member

You are correct! Thanks for pointing this out. Reopening.

@alexcrichton alexcrichton reopened this Sep 24, 2013
@ghost ghost assigned alexcrichton Sep 24, 2013
alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 24, 2013
@alexcrichton
Emit purity to function dox
61ce98d 
Closes rust-lang#3804
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 24, 2020
@bors
Auto merge of rust-lang#6144 - rust-lang:float-cmp-ref, r=ebroto
0b86340 
allow refs in our constant folder

This helps with rust-lang#3804 (but won't completely fix it).

---

changelog: none
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@calebcartwright @topecongiro
fix: handling of empty str for license template path (rust-lang#3804)
3bb2661
@Kingcrypto38 Kingcrypto38 mentioned this issue Apr 3, 2024
Open
@aravindb26 aravindb26 mentioned this issue Apr 3, 2024
Open
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 30, 2024
@bors
Auto merge of rust-lang#3804 - tiif:blockit, r=oli-obk
2d69baa 
Support blocking for epoll

This PR enabled epoll to have blocking operation.

The changes introduced by this PR are:
- Refactored part of the logic in ``epoll_wait`` to ``blocking_epoll_callback``
- Added a new field ``thread_ids`` in ``Epoll`` for blocked thread ids
- Added a new ``BlockReason::Epoll``
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 30, 2024
@bors
Auto merge of rust-lang#3848 - tiif:tokiotest, r=RalfJung
79115f5 
Add tokio io test

After rust-lang#3804 landed, these tests passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
4 participants
@sanxiyn @alexcrichton @brson @dckc