ci: Move global credentials to web configuration #55304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bors
added a commit
that referenced
this pull request
Oct 24, 2018
ci: Move global credentials to web configuration This commit moves a number of our encrypted credentials stored in configuration files in this repository to env vars on the web UI. This will hopefully make it easier to rotate credentials in the future as well as quickly change them if the need arises. (quicker than landing a PR that is). This also updates the travis deployment process to always use the `aws` command line tool which we're already installing on Linux and should enable us to avoid all `dpl` gem issues as well as have greater control over what's going where.
kennytm
reviewed
Oct 24, 2018
.travis.yml
Outdated
| @@ -21,12 +36,14 @@ matrix: | |||
|
|
|||
| - env: IMAGE=dist-x86_64-linux DEPLOY=1 | |||
| if: branch = try OR branch = auto | |||
| after_success: *DEPLOY | |||
There was a problem hiding this comment.
🤔 Could we put that &DEPLOY reference into the global after_success section (which is configured to do nothing if $DEPLOY and $DEPLOY_ALT are undefined), so we don't need to add these dozen lines inside the matrix:
There was a problem hiding this comment.
Sure thing, sounds reasonable to me!
|
☀️ Test successful - status-travis |
This commit moves a number of our encrypted credentials stored in configuration files in this repository to env vars on the web UI. This will hopefully make it easier to rotate credentials in the future as well as quickly change them if the need arises. (quicker than landing a PR that is). This also updates the travis deployment process to always use the `aws` command line tool which we're already installing on Linux and should enable us to avoid all `dpl` gem issues as well as have greater control over what's going where.
alexcrichton
force-pushed
the
update-credentials
branch
from
52f02da to
3c25f80
Compare
|
Ok try builds look good! Appears that files were indeed successfully uploaded |
|
@bors r+ |
|
📌 Commit 3c25f80 has been approved by |
bors
added
S-waiting-on-bors
|
@bors r- Failed in #55433 (comment)
|
bors
added
S-waiting-on-author
|
I've asked a question to see whether this way of configuration actually should work, and will reevaluate based on the answer |
|
@bors: r=kennytm Ok I think I may have messed up the keys. In any case I wouldn't recommend rolling this up |
|
📌 Commit 3c25f80 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 30, 2018
ci: Move global credentials to web configuration This commit moves a number of our encrypted credentials stored in configuration files in this repository to env vars on the web UI. This will hopefully make it easier to rotate credentials in the future as well as quickly change them if the need arises. (quicker than landing a PR that is). This also updates the travis deployment process to always use the `aws` command line tool which we're already installing on Linux and should enable us to avoid all `dpl` gem issues as well as have greater control over what's going where.
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
@bors: retry 3 hr time limit |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 31, 2018
ci: Move global credentials to web configuration This commit moves a number of our encrypted credentials stored in configuration files in this repository to env vars on the web UI. This will hopefully make it easier to rotate credentials in the future as well as quickly change them if the need arises. (quicker than landing a PR that is). This also updates the travis deployment process to always use the `aws` command line tool which we're already installing on Linux and should enable us to avoid all `dpl` gem issues as well as have greater control over what's going where.
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves a number of our encrypted credentials stored in
configuration files in this repository to env vars on the web UI. This
will hopefully make it easier to rotate credentials in the future as
well as quickly change them if the need arises. (quicker than landing a
PR that is).
This also updates the travis deployment process to always use the
awscommand line tool which we're already installing on Linux and should
enable us to avoid all
dplgem issues as well as have greater controlover what's going where.