Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Use dyn keyword when rendering dynamic traits #55077

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Oct 15, 2018

The dyn keyword has been stable for a while now so rustdoc should start using it.

r? @QuietMisdreavus

The dyn keyword has been stable for a while now so rustdoc should start using it.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2018
@QuietMisdreavus
Copy link
Member

cc @rust-lang/docs; this makes rustdoc unilaterally print dyn when rendering trait objects. This is probably fine, but it's something worth noting.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 17, 2018

📌 Commit 86d5a33 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2018
@GuillaumeGomez
Copy link
Member

Even if not defined as dyn in the source code? It might be a bit surprising. Not sure if this what we want...

kennytm added a commit to kennytm/rust that referenced this pull request Oct 18, 2018
…isdreavus

rustdoc: Use dyn keyword when rendering dynamic traits

The dyn keyword has been stable for a while now so rustdoc should start using it.

r? @QuietMisdreavus
bors added a commit that referenced this pull request Oct 18, 2018
Rollup of 18 pull requests

Successful merges:

 - #54646 (improve documentation on std::thread::sleep)
 - #54933 (Cleanup the rest of codegen_llvm)
 - #54964 (Run both lldb and gdb tests)
 - #55016 (Deduplicate some code and compile-time values around vtables)
 - #55031 (Improve verify_llvm_ir config option)
 - #55050 (doc std::fmt: the Python inspiration is already mentioned in precedin…)
 - #55077 (rustdoc: Use dyn keyword when rendering dynamic traits)
 - #55080 (Detect if access to localStorage is forbidden by the user's browser)
 - #55090 (regression test for move out of borrow via pattern)
 - #55102 (resolve: Do not skip extern prelude during speculative resolution)
 - #55104 (Add test for #34229)
 - #55111 ([Rustc Book] Explain --cfg's arguments)
 - #55122 (Cleanup mir/borrowck)
 - #55127 (Remove HybridBitSet::dummy)
 - #55128 (Fix LLVMRustInlineAsmVerify return type mismatch)
 - #55142 (miri: layout should not affect CTFE checks (outside of validation))
 - #55151 (Cleanup nll)
 - #55161 ([librustdoc] Disable spellcheck for search field)
@bors bors merged commit 86d5a33 into rust-lang:master Oct 18, 2018
@ollie27 ollie27 deleted the rustdoc_dyn_trait branch October 18, 2018 10:24
@ollie27
Copy link
Member Author

ollie27 commented Oct 18, 2018

Even if not defined as dyn in the source code? It might be a bit surprising. Not sure if this what we want...

I should point out that rustc has been using the dyn keyword unconditionally in error messages since #51104 so this is constant with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants