duplicated errors for invalid derives #34229
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
E-needs-test
Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Comments
Mark-Simulacrum
added
the
A-diagnostics
Mark-Simulacrum
added
the
C-enhancement
|
Would the following be possible?:
It doesn't address all cases, but it would significantly improve this one. |
arielb1
added
the
E-needs-test
|
Should this be a UI or compile-fail test? I think cfail is out of favor these days, but a UI test will have to include a bug: #45519 (comment) |
|
It should be a UI test, I'd say and we should fix that bug |
Merged
estebank
added a commit
to estebank/rust
that referenced
this issue
Oct 15, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Oct 18, 2018
bors
added a commit
that referenced
this issue
Oct 18, 2018
Rollup of 18 pull requests Successful merges: - #54646 (improve documentation on std::thread::sleep) - #54933 (Cleanup the rest of codegen_llvm) - #54964 (Run both lldb and gdb tests) - #55016 (Deduplicate some code and compile-time values around vtables) - #55031 (Improve verify_llvm_ir config option) - #55050 (doc std::fmt: the Python inspiration is already mentioned in precedin…) - #55077 (rustdoc: Use dyn keyword when rendering dynamic traits) - #55080 (Detect if access to localStorage is forbidden by the user's browser) - #55090 (regression test for move out of borrow via pattern) - #55102 (resolve: Do not skip extern prelude during speculative resolution) - #55104 (Add test for #34229) - #55111 ([Rustc Book] Explain --cfg's arguments) - #55122 (Cleanup mir/borrowck) - #55127 (Remove HybridBitSet::dummy) - #55128 (Fix LLVMRustInlineAsmVerify return type mismatch) - #55142 (miri: layout should not affect CTFE checks (outside of validation)) - #55151 (Cleanup nll) - #55161 ([librustdoc] Disable spellcheck for search field)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This code attempts to derive
PartialOrdin an invalid situation, and is rewarded with a barrage of duplicate errors:The error
the trait core::cmp::PartialOrd is not implemented for the type Comparableonly appears once. However, the errorbinary operation < cannot be applied to type Comparable(along with notean implementation of std::cmp::PartialOrd might be missing for Comparable... gee, really?) appears eight times, four for<and four for>.I assume this is because an error is generated at several points within the (invisible) generated
PartialOrdimplementation. But since they are all assigned the same span, maybe we can deduplicate.The text was updated successfully, but these errors were encountered: