Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for issue-48238 #49295

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Add test for issue-48238 #49295

merged 1 commit into from
Mar 23, 2018

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Mar 23, 2018

Fixes #48238
test case made from comments in #48238

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2018
@alexcrichton
Copy link
Member

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Mar 23, 2018

📌 Commit ced7687 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2018
@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49295 - csmoe:nll_test_48238, r=alexcrichton
d58abe7 
Add test for issue-48238

Fixes rust-lang#48238
test case made from comments in rust-lang#48238
bors added a commit that referenced this pull request Mar 23, 2018
@bors
Auto merge of #49308 - alexcrichton:rollup, r=alexcrichton
c08480f 
Rollup of 15 pull requests

- Successful merges: #48265, #48528, #48552, #48624, #48883, #48909, #49028, #49030, #49102, #49160, #49169, #49203, #49262, #49272, #49295
- Failed merges: #48942, #49035
@alexcrichton alexcrichton merged commit ced7687 into rust-lang:master Mar 23, 2018
@csmoe csmoe deleted the nll_test_48238 branch July 13, 2018 08:44
@acrrd acrrd mentioned this pull request May 4, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csmoe @rust-highfive @alexcrichton @bors