-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracking issue for bugs fixed by the MIR borrow checker or NLL #47366
Labels
A-NLL
Area: Non-lexical lifetimes (NLL)
C-bug
Category: This is a bug.
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
NLL-fixed-by-NLL
Bugs fixed, but only when NLL is enabled.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
nikomatsakis
added
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
WG-compiler-nll
labels
Jan 11, 2018
I'll take this. Looks straightforward. |
Added #45045 to the list. |
This isn't meant to be closed but rather kept open as a record of the issues involved. =) |
Added #46314 to the list |
nikomatsakis
changed the title
add tests for bugs fixed by the MIR borrow checker
tracking issue for bugs fixed by the MIR borrow checker
Jan 16, 2018
This was referenced Jan 16, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Jan 17, 2018
Add NLL test for rust-lang#45045 cc rust-lang#45045 Part of rust-lang#47366 r? @nikomatsakis
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Jan 17, 2018
Add NLL test for rust-lang#45045 cc rust-lang#45045 Part of rust-lang#47366 r? @nikomatsakis
pnkfelix
changed the title
tracking issue for bugs fixed by the MIR borrow checker
tracking issue for bugs fixed by the MIR borrow checker or NLL
Jan 18, 2018
Added #29723 |
Added #16223 |
This was referenced Feb 21, 2018
Closed
nikomatsakis
added
the
NLL-fixed-by-NLL
Bugs fixed, but only when NLL is enabled.
label
Mar 14, 2018
This was referenced Apr 3, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this issue
Apr 4, 2018
…komatsakis Regression test for rust-lang#46314 rust-lang#46314 is fixed by NLL. This PR adds a regression test for the bug. Intended for rust-lang#47366.
jkordish
added
C-bug
Category: This is a bug.
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
labels
Apr 17, 2018
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this issue
Aug 17, 2018
…omatsakis [nll] add regression test for issue rust-lang#27868 Adds a test for rust-lang#27868 ``Inconsistent evaluation order for assignment operations`` apart of rust-lang#47366 ``tracking issue for bugs fixed by the MIR borrow checker or NLL`` r? @nikomatsakis
nikomatsakis
added
A-NLL
Area: Non-lexical lifetimes (NLL)
and removed
WG-compiler-nll
labels
Aug 27, 2018
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 26, 2019
…hewjasper Rust 2015: No longer downgrade NLL errors As per decision on a language team meeting as described in rust-lang#63565 (comment), in Rust 2015, we refuse to downgrade NLL errors, that AST borrowck accepts, into warnings and keep them as hard errors. The remaining work to throw out AST borrowck and adjust some tests still remains after this PR. Fixes rust-lang#38899 Fixes rust-lang#53432 Fixes rust-lang#45157 Fixes rust-lang#31567 Fixes rust-lang#27868 Fixes rust-lang#47366 r? @matthewjasper
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 26, 2019
…hewjasper Rust 2015: No longer downgrade NLL errors As per decision on a language team meeting as described in rust-lang#63565 (comment), in Rust 2015, we refuse to downgrade NLL errors, that AST borrowck accepts, into warnings and keep them as hard errors. The remaining work to throw out AST borrowck and adjust some tests still remains after this PR. Fixes rust-lang#38899 Fixes rust-lang#53432 Fixes rust-lang#45157 Fixes rust-lang#31567 Fixes rust-lang#27868 Fixes rust-lang#47366 r? @matthewjasper
Centril
added a commit
to Centril/rust
that referenced
this issue
Sep 26, 2019
…hewjasper Rust 2015: No longer downgrade NLL errors As per decision on a language team meeting as described in rust-lang#63565 (comment), in Rust 2015, we refuse to downgrade NLL errors, that AST borrowck accepts, into warnings and keep them as hard errors. The remaining work to throw out AST borrowck and adjust some tests still remains after this PR. Fixes rust-lang#38899 Fixes rust-lang#53432 Fixes rust-lang#45157 Fixes rust-lang#31567 Fixes rust-lang#27868 Fixes rust-lang#47366 r? @matthewjasper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-NLL
Area: Non-lexical lifetimes (NLL)
C-bug
Category: This is a bug.
C-tracking-issue
Category: A tracking issue for an RFC or an unstable feature.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
NLL-fixed-by-NLL
Bugs fixed, but only when NLL is enabled.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Part of: #43234
The MIR-based borrow checker used by NLL fixes a number of bugs in the existing AST-based borrow checker. Our plan for these bugs is to fix them by transitioning to the MIR-based borrow checker. In the meantime, we wish to add tests that show that the bugs are fixed with NLL, and then close the bugs (so they don't clutter up the issue tracker). This issue tracks the set of such bugs and gives instructions for how to proceed.
Bugs fixed by MIR
All these bugs are confirmed as fixed; the checkmark indicates that a PR with a test is enqueued or landed.
&T
sometimes incorrectly allowed #38899decl_macro
#46314decl_macro
#46314 (hygiene interaction)Procedure
src/test/ui/nll/
issue-XXX.rs
, though giving a more descriptive name is also good// Regression test for #XXX
however to ease searching later#![feature(nll)]
at the top//~ ERROR
for the errors, or whatever is needed for test harness to pass./x.py test --stage 1 src/test/ui --test-args nll
, this will test all the nll tests (including yours)r? @nikomatsakis
in the PR summaryThe text was updated successfully, but these errors were encountered: