Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect illegal hidden lifetimes in impl Trait #49041

Merged

Commits on Mar 20, 2018

  1. Configuration menu
    Copy the full SHA
    a9cbfaa View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2018

  1. report an error if we see an unexpected lifetime in impl Trait

    But leave closure substs alone.
    nikomatsakis committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    fc3c90c View commit details
    Browse the repository at this point in the history
  2. use subtyping when we create a closure instead of for upvar types

    We used to make the upvar types in the closure `==` but that was
    stronger than we needed. Subtyping suffices, since we are copying the
    upvar value into the closure field. This in turn allows us to infer
    smaller lifetimes in captured values in some cases (like the example
    here), avoiding errors.
    nikomatsakis committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    f71de45 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d5ec9e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    94eebaa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3955708 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    48c4e35 View commit details
    Browse the repository at this point in the history
  7. also fix the Fixed code

    nikomatsakis committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    2e8a1ab View commit details
    Browse the repository at this point in the history