Detect illegal hidden lifetimes in impl Trait
#49041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
29 tasks
nikomatsakis
force-pushed
the
issue-46541-impl-trait-hidden-lifetimes
branch
3 times, most recently
from
12f01cd
to
3901391
Compare
|
Ping from triage @cramertj! This PR needs your review. |
|
This seems fine to me so far, but I think @nikomatsakis was going to push some updates to the behavior of lifetimes inside of closures. @nikomatsakis is that still your plan? |
|
@cramertj I did that already |
|
Is the remaining travis failure ( |
|
@cramertj I saw it now, I'll go try and fix it |
nikomatsakis
force-pushed
the
issue-46541-impl-trait-hidden-lifetimes
branch
from
3901391
to
60b9558
Compare
|
(@nikomatsakis travis is still mad) |
|
@cramertj yeah I didn't start trying to fix it yet :) |
But leave closure substs alone.
We used to make the upvar types in the closure `==` but that was stronger than we needed. Subtyping suffices, since we are copying the upvar value into the closure field. This in turn allows us to infer smaller lifetimes in captured values in some cases (like the example here), avoiding errors.
nikomatsakis
force-pushed
the
issue-46541-impl-trait-hidden-lifetimes
branch
from
60b9558
to
9d5ec9e
Compare
|
@cramertj ok fixed now (I think) |
nikomatsakis
changed the title
impl Traitimpl Trait
|
Travis still red. |
|
Yeah, spoke a bit prematurely. I fixed a few more things. |
|
(@nikomatsakis just in case you weren't aware, this is still red) |
|
@bors r+ p=10 |
|
📌 Commit 2e8a1ab has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 22, 2018
…etimes, r=cramertj Detect illegal hidden lifetimes in `impl Trait` This branch fixes #46541 -- however, it presently doesn't build because it also *breaks* a number of existing usages of impl Trait. I'm opening it as a WIP for now, just because we want to move on impl Trait, but I'll try to fix the problem in a bit. ~~(The problem is due to the fact that we apparently infer stricter lifetimes in closures that we need to; for example, if you capture a variable of type `&'a &'b u32`, we will put *precisely* those lifetimes into the closure, even if the closure would be happy with `&'a &'a u32`. This causes the present chance to affect things that are not invariant.)~~ fixed r? @cramertj
|
☀️ Test successful - status-appveyor, status-travis |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 24, 2018
…atsakis Stabilize impl Trait Blocked on: - [x] rust-lang#49041 and - [ ] completion of FCP in rust-lang#34511 (comment) (3 days from now). I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).
bors
added a commit
that referenced
this pull request
Mar 26, 2018
Stabilize impl Trait Blocked on: - [x] #49041 and - [ ] completion of FCP in #34511 (comment) (3 days from now). I have not yet done any docs work for this-- I probably won't get to it until this weekend (might be a project for the flight to the all-hands).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes #46541 -- however, it presently doesn't build because it also breaks a number of existing usages of impl Trait. I'm opening it as a WIP for now, just because we want to move on impl Trait, but I'll try to fix the problem in a bit.
(The problem is due to the fact that we apparently infer stricter lifetimes in closures that we need to; for example, if you capture a variable of typefixed&'a &'b u32, we will put precisely those lifetimes into the closure, even if the closure would be happy with&'a &'a u32. This causes the present chance to affect things that are not invariant.)r? @cramertj