Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 23 pull requests #48203

Merged
merged 75 commits into from
Feb 15, 2018
Merged

Rollup of 23 pull requests #48203

merged 75 commits into from
Feb 15, 2018

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Feb 14, 2018

PramodBisht and others added 30 commits January 27, 2018 20:00
During the RFC, it was discussed that figuring out whether a range is empty was subtle, and thus there should be a clear and obvious way to do it.  It can't just be ExactSizeIterator::is_empty (also unstable) because not all ranges are ExactSize -- not even Range<i32> or RangeInclusive<usize>.
When encountering a variadic argument in a function definition that
doesn't accept it, if immediately after there's a closing paren,
continue parsing as normal. Otherwise keep current behavior of emitting
error and stopping.
@bors
Copy link
Contributor

bors commented Feb 15, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@kennytm
Copy link
Member Author

kennytm commented Feb 15, 2018

@bors retry #46903

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018
…_api_docs, r=QuietMisdreavus

Clarified why `Sized` bound not implicit on trait's implicit `Self` type.

This part of the documentation was a little confusing to me on first read. I've added a couple lines for further explanation. Hopefully this makes things a bit clearer for new readers.
@kennytm kennytm changed the title Rollup of 22 pull requests Rollup of 23 pull requests Feb 15, 2018
@kennytm
Copy link
Member Author

kennytm commented Feb 15, 2018

@bors r+

Added #48210

@bors
Copy link
Contributor

bors commented Feb 15, 2018

📌 Commit 03b089d has been approved by kennytm

@bors
Copy link
Contributor

bors commented Feb 15, 2018

⌛ Testing commit 03b089d with merge d33cb35a5082482863909e3cb8e25c903ca2200c...

@bors
Copy link
Contributor

bors commented Feb 15, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@kennytm
Copy link
Member Author

kennytm commented Feb 15, 2018

@bors retry #46903

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2018
@bors
Copy link
Contributor

bors commented Feb 15, 2018

⌛ Testing commit 03b089d with merge 1670a53...

bors added a commit that referenced this pull request Feb 15, 2018
@bors
Copy link
Contributor

bors commented Feb 15, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2018
@kennytm kennytm merged commit 03b089d into rust-lang:master Feb 15, 2018
@kennytm
Copy link
Member Author

kennytm commented Feb 15, 2018

Manually merged, #46903 again, and previous tests https://ci.appveyor.com/project/rust-lang/rust/build/1.0.6355 already showed i686-pc-windows-gnu is good.

@bors bors mentioned this pull request Feb 15, 2018
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.