Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Upgrade libcompiler-builtins #45779

Closed
wants to merge 1 commit into from

Conversation

ishitatsuyuki
Copy link
Contributor

r? @alexcrichton

The plan is perform a try, get the artifacts and check if the sanitizers work.

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 5, 2017
@kennytm
Copy link
Member

kennytm commented Nov 5, 2017

The CI is green? You need to modify .travis.yml to enable the ARM jobs if you want to try those.

@ishitatsuyuki
Copy link
Contributor Author

No, no. Sanitizers are never tested in CI, so we need an artifact to do so. ARM is unrelated to sanitizers.

@kennytm
Copy link
Member

kennytm commented Nov 5, 2017

I see.

@ishitatsuyuki
Copy link
Contributor Author

Can anyone with privilege run a try?

@kennytm
Copy link
Member

kennytm commented Nov 6, 2017

@ishitatsuyuki The try build won't run any tests. Or do you just want to get a compiler artifact?

@ishitatsuyuki
Copy link
Contributor Author

Yes, I want an artifact.

@kennytm
Copy link
Member

kennytm commented Nov 6, 2017

@bors try

@bors
Copy link
Contributor

bors commented Nov 6, 2017

⌛ Trying commit 5d9f51f with merge d0bb1acac6b8f99d97fc6a43d2d974088012cfe4...

@bors
Copy link
Contributor

bors commented Nov 6, 2017

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton
Copy link
Member

For others watching, this is related to rust-lang/compiler-builtins#202. I'm still not super comfortable merging an update to compiler-rt without also updating LLVM, AFAIK they're meant to be kept in tandem and it seems like ripe opportunity for subtle bugs if they get out of sync.

@ishitatsuyuki
Copy link
Contributor Author

@alexcrichton, test results:

ASan in release mode seems partially broken. Invalid memory accesses doesn't trigger an error, but LeakSanitizer does kick in.

ASan in debug mode doesn't compile at all due to #45220. -Ccodegen-units=1 doesn't have an effect.

Maybe LLVM upgrade is needed then. Feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants