-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Upgrade libcompiler-builtins #45779
Conversation
The CI is green? You need to modify |
No, no. Sanitizers are never tested in CI, so we need an artifact to do so. ARM is unrelated to sanitizers. |
I see. |
Can anyone with privilege run a try? |
@ishitatsuyuki The |
Yes, I want an artifact. |
@bors try |
⌛ Trying commit 5d9f51f with merge d0bb1acac6b8f99d97fc6a43d2d974088012cfe4... |
☀️ Test successful - status-travis |
For others watching, this is related to rust-lang/compiler-builtins#202. I'm still not super comfortable merging an update to compiler-rt without also updating LLVM, AFAIK they're meant to be kept in tandem and it seems like ripe opportunity for subtle bugs if they get out of sync. |
@alexcrichton, test results: ASan in release mode seems partially broken. Invalid memory accesses doesn't trigger an error, but LeakSanitizer does kick in. ASan in debug mode doesn't compile at all due to #45220. Maybe LLVM upgrade is needed then. Feel free to close. |
r? @alexcrichton
The plan is perform a try, get the artifacts and check if the sanitizers work.