Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler-rt submodule #202

Closed
wants to merge 1 commit into from
Closed

Update compiler-rt submodule #202

wants to merge 1 commit into from

Conversation

ishitatsuyuki
Copy link

This brings in LLVM 5 related changes. Not tested.

This brings in LLVM 5 related changes.
@ishitatsuyuki
Copy link
Author

CI failure due to homebrew failing on outdated Ruby.

@alexcrichton
Copy link
Member

I don't think we're ready for LLVM 5 to land upstream in rustc, so why would we land this ahead of time?

@ishitatsuyuki
Copy link
Author

There's sanitizer linkage issues; and we're behind the schedule.

@alexcrichton
Copy link
Member

That's... not really an answer though? We can't land this until we can upgrade to LLVM 5, right?

@Amanieu
Copy link
Member

Amanieu commented Nov 2, 2017

compiler-rt doesn't depend on LLVM and can be updated independently.

@ishitatsuyuki
Copy link
Author

  • the current code base has compile issues with glibc 2.26.
  • the current code base is incompatible with latest LLVM sanitizers.
  • the upgrade should be back compat, but it may cause the sanitizers to fail weird. Needs test.

@alexcrichton
Copy link
Member

Aren't the newer sanitizers not guaranteed to be compatible with older LLVM? Are we sure that this upgrade of the compiler-rt submodule actually works with the LLVM rustc is using?

@ishitatsuyuki
Copy link
Author

Let's test it. I will open a WIP PR to rust repo tomorrow.

@alexcrichton
Copy link
Member

According to rust-lang/rust#45779 sounds like we're not quite ready for this, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants