Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #42012

Closed
wants to merge 16 commits into from
Closed

Rollup of 6 pull requests #42012

wants to merge 16 commits into from

Commits on May 14, 2017

  1. Explain why thread::yield_now could be used.

    Felix Raimundo committed May 14, 2017
    Configuration menu
    Copy the full SHA
    a9cb094 View commit details
    Browse the repository at this point in the history
  2. Improve thread::Builder documentation.

    Part of rust-lang#29378 .
    
    - In particular explains *why* we would use the builder instead of
      the free function.
    - Changes the parent-child explanation for a spawned-caller.
    - Add link to `io::Result` in `thread::Builder`
    - Corrects the `thread::Builder::spawn` documentation.
    Felix Raimundo committed May 14, 2017
    Configuration menu
    Copy the full SHA
    a51777e View commit details
    Browse the repository at this point in the history
  3. Remove rustc_llvm dependency from rustc_metadata

    Move the code for loading metadata from rlibs and dylibs from
    rustc_metadata into rustc_trans, and introduce a trait to avoid
    introducing a direct dependency on rustc_trans.
    
    This means rustc_metadata is no longer rebuilt when LLVM changes.
    Robin Kruppe committed May 14, 2017
    Configuration menu
    Copy the full SHA
    1a24a59 View commit details
    Browse the repository at this point in the history
  4. appveyor: Wrap handle.exe download in a retry

    Should help deal with spurious download failures.
    alexcrichton committed May 14, 2017
    Configuration menu
    Copy the full SHA
    e5ec073 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2017

  1. Make unsatisfied trait bounds note multiline

    Make diagnostic note for existing method with unsatisfied trait bounds
    multiline for cleaner output.
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied:
              `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
              `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    
    Before:
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    ```
    estebank committed May 15, 2017
    Configuration menu
    Copy the full SHA
    c0d5aa8 View commit details
    Browse the repository at this point in the history
  2. Add links to the thread::LocalKey doc.

    Part of rust-lang#29378 .
    Felix Raimundo committed May 15, 2017
    Configuration menu
    Copy the full SHA
    f92bd3d View commit details
    Browse the repository at this point in the history
  3. Remove rustc_llvm dependency from librustc

    Consequently, session creation can no longer initialize LLVM.
    The few places that use the compiler without going through
    rustc_driver/CompilerCalls thus need to be careful to manually
    initialize LLVM (via rustc_trans!) immediately after session
    creation.
    
    This means librustc is not rebuilt when LLVM changes.
    Robin Kruppe committed May 15, 2017
    Configuration menu
    Copy the full SHA
    8e4f315 View commit details
    Browse the repository at this point in the history
  4. Remove (direct) rustc_llvm dependency from rustc_driver

    This does not actually improve build times, since it still depends
    on rustc_trans, but is better layering and fits the multi-backend
    future slightly better.
    Robin Kruppe committed May 15, 2017
    Configuration menu
    Copy the full SHA
    e3f6e68 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    acdeedc View commit details
    Browse the repository at this point in the history
  6. Fix run-make/llvm-pass

    Robin Kruppe committed May 15, 2017
    Configuration menu
    Copy the full SHA
    04a16ff View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#41489 - estebank:trait-bounds-diagnosstic, …

    …r=arielb1
    
    Make unsatisfied trait bounds note multiline
    
    Make diagnostic note for existing method with unsatisfied trait bounds
    multiline for cleaner output.
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied:
              `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`
              `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>> [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    ```
    
    Before:
    
    ```
      = note: the method `count` exists but the following trait bounds were not satisfied: `[closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53] : std::ops::FnMut<(&_,)>`, `std::iter::Filter<std::iter::Fuse<std::iter::Once<&str>>, [closure@../../src/test/compile-fail/issue-36053-2.rs:17:39: 17:53]> : std::iter::Iterator`
    ```
    frewsxcv committed May 15, 2017
    Configuration menu
    Copy the full SHA
    3a6bc95 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#41565 - rkruppe:llvm-sys, r=eddyb

    Make only rustc_trans depend on rustc_llvm
    
    With these changes, only rustc_trans depends directly on rustc_llvm (and no crate gained a new dependency on trans). This means changing LLVM doesn't rebuild librustc or rustc_metadata, only rustc_trans, rustc_driver and the rustc executable
    Also, rustc_driver technically doesn't know about LLVM any more (of course, it still handles a ton of options that conceptually refer to LLVM, but it delegates their implementation to trans).
    
    What I *didn't* implement was merging most or all of rustc_llvm into rustc_trans. I ran into a nasty bug, which was probably just a silly typo somewhere but I probably won't have the time to figure it out in the next week or two. I opened rust-lang#41699 for that step.
    
    Fixes rust-lang#41473
    frewsxcv committed May 15, 2017
    Configuration menu
    Copy the full SHA
    3cadd37 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

    …umeGomez
    
    [Doc] Explain why `thread::yield_now` could be used.
    
    Part of rust-lang#29378.
    
    r? @steveklabnik
    frewsxcv committed May 15, 2017
    Configuration menu
    Copy the full SHA
    a341d40 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#41994 - gamazeps:thread-builder, r=Guillaum…

    …eGomez
    
    [Doc] Implrove `thread::Builder`'s doc.
    
    Part of rust-lang#29378 .
    
    - Explains *why* we would use the builder instead ofthe free function.
    - Changes the parent-child explanation for a spawned-caller in `thread::Builder::spawn`
    - Adds a link to `io::Result` in `thread::Builder`
    - Corrects the return type doc in `thread::Builder::spawn`
    
    r? @rust-lang/docs
    frewsxcv committed May 15, 2017
    Configuration menu
    Copy the full SHA
    0c4f3c0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#41995 - gamazeps:thread-localkey, r=frewsxcv

    [Doc] Add links to the `thread::LocalKey` doc.
    
    Part of rust-lang#29378 .
    
    I do not know exactly what should be done for the `cleanup` part, if you have any idea I'll gladly do it.
    
    r? @rust-lang/docs
    frewsxcv committed May 15, 2017
    Configuration menu
    Copy the full SHA
    0d51303 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#41996 - alexcrichton:more-retry, r=Mark-Sim…

    …ulacrum
    
    appveyor: Wrap handle.exe download in a retry
    
    Should help deal with spurious download failures.
    frewsxcv committed May 15, 2017
    Configuration menu
    Copy the full SHA
    7a07937 View commit details
    Browse the repository at this point in the history