New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Explain why `thread::yield_now` could be used. #41982

Merged

bors merged 1 commit into rust-lang:master from gamazeps:thread-yield-now

May 16, 2017

Contributor

gamazeps commented May 13, 2017

Part of #29378.

r? @steveklabnik

rust-highfive assigned steveklabnik

gamazeps changed the title ~~Explain why thread::yield_now could be used.~~ [Doc] Explain why thread::yield_now could be used.

gamazeps force-pushed the thread-yield-now branch from da17932 to 7a27e26 Compare

May 14, 2017 11:45

Contributor Author

gamazeps commented May 14, 2017 •

edited by GuillaumeGomez

Loading

r? @rust-lang/docs

rust-highfive unassigned steveklabnik

GuillaumeGomez reviewed

View reviewed changes

src/libstd/thread/mod.rs Outdated

    
              ///

              /// For example when polling on a resource, it is common to check that it is

              /// available, and if not to yield in order to avoid busy waiting. Thus the

              /// poll then yield, is a rather common pattern when implementing low-level

Member

GuillaumeGomez May 14, 2017

This sentence is a bit confusing. "the poll then yield" for example is a bit hard to understand with just one reading. Don't hesitate to make the sentence longer if it helps the reader to understand more easily.

Contributor Author

gamazeps May 14, 2017

Done :)


          Explain why thread::yield_now could be used.

a9cb094

Part of rust-lang#29378.

gamazeps force-pushed the thread-yield-now branch from 7a27e26 to a9cb094 Compare

May 14, 2017 12:05

Member

GuillaumeGomez commented May 14, 2017

Thanks!

@bors: r+ rollup

Contributor

bors commented May 14, 2017

📌 Commit a9cb094 has been approved by GuillaumeGomez

Contributor

bors commented May 14, 2017

⌛ Testing commit a9cb094 with merge c5ce0e6...

bors added a commit that referenced this pull request


          Auto merge of #41982 - gamazeps:thread-yield-now, r=GuillaumeGomez

c5ce0e6

[Doc] Explain why `thread::yield_now` could be used.

Part of #29378.

r? @steveklabnik

Mark-Simulacrum added the S-waiting-on-bors label

Contributor

bors commented May 14, 2017

💔 Test failed - status-appveyor

Member

Mark-Simulacrum commented May 14, 2017

Looks like tests just... hung? Stopped? I can't really tell. Either way, there's practically no way for that to be the fault of this PR.

@bors retry

Contributor

bors commented May 14, 2017

⌛ Testing commit a9cb094 with merge 4c409dd...

frewsxcv added the A-docs label

Contributor

bors commented May 14, 2017

💔 Test failed - status-appveyor

Member

Mark-Simulacrum commented May 14, 2017

test malformed_override ... ok
test unused_keys ... ok
test both_git_and_path_specified has been running for over 60 seconds

@bors retry

Maybe Tracking issue for spurious network failures on bots #40474, but maybe not. Cargo-related.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request


          Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

6c3665d

…umeGomez

[Doc] Explain why `thread::yield_now` could be used.

Part of rust-lang#29378.

r? @steveklabnik

Mark-Simulacrum mentioned this pull request

Rollup of 4 pull requests #41999

Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request


          Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

69d50aa

…umeGomez

[Doc] Explain why `thread::yield_now` could be used.

Part of rust-lang#29378.

r? @steveklabnik

frewsxcv mentioned this pull request

Rollup of 7 pull requests #42010

Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request


          Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

a341d40

…umeGomez

[Doc] Explain why `thread::yield_now` could be used.

Part of rust-lang#29378.

r? @steveklabnik

frewsxcv mentioned this pull request

Rollup of 6 pull requests #42012

Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request


          Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

25a739c

…umeGomez

[Doc] Explain why `thread::yield_now` could be used.

Part of rust-lang#29378.

r? @steveklabnik

frewsxcv mentioned this pull request

Rollup of 6 pull requests #42022

Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request


          Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

e4a4f53

…umeGomez

[Doc] Explain why `thread::yield_now` could be used.

Part of rust-lang#29378.

r? @steveklabnik

Mark-Simulacrum mentioned this pull request

Rollup of 8 pull requests #42032

Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request


          Rollup merge of rust-lang#41982 - gamazeps:thread-yield-now, r=Guilla…

efe285e

…umeGomez

[Doc] Explain why `thread::yield_now` could be used.

Part of rust-lang#29378.

r? @steveklabnik

Mark-Simulacrum mentioned this pull request

Rollup of 8 pull requests #42038

Merged

bors added a commit that referenced this pull request


          Auto merge of #42038 - Mark-Simulacrum:rollup, r=Mark-Simulacrum

0f68728

Rollup of 8 pull requests

- Successful merges: #41489, #41982, #41994, #41995, #42001, #42005, #42011, #42028
- Failed merges:

bors merged commit a9cb094 into rust-lang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docs S-waiting-on-bors