Reenable opt-level 3 #41967
Merged
Reenable opt-level 3 #41967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment is quite old, let's see what would happen with current MSVC.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Tested this locally, everything looks ok, lets's see what AppVeyor says. |
|
📌 Commit 30383b2 has been approved by |
|
Uh, by the way this would probably fail due to a bug hidden by different optimization levels resulting in different metadata. (Fixed in #41639) Anyway, let's see how AppVeyor behaves, if we were lucky enough to not get it cancelled. |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
May 13, 2017
Reenable opt-level 3 This comment is quite old, let's see what would happen with current MSVC. Since there's no AppVeyor test for PR, the best way is to try if it get through homu. I don't recommend doing this in roll-up.
Mark-Simulacrum
added
the
S-waiting-on-author
|
@ishitatsuyuki did you mean to close this? |
|
@bors: r+ |
|
📌 Commit 30383b2 has been approved by |
Mark-Simulacrum
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 20, 2017
Reenable opt-level 3 This comment is quite old, let's see what would happen with current MSVC. Since there's no AppVeyor test for PR, the best way is to try if it get through homu. I don't recommend doing this in roll-up.
|
☀️ Test successful - status-appveyor, status-travis |
|
Heh, as what I expected, this is slightly slower probably due to CPU cache blowing. If we're going to lower the default optimize level, the discussion should be done separately, and the change should apply to all projects. EDIT: I'm not sure if the slowdown is caused by simply running more LLVM passes. We should confirm this with the perf dashboard results. |
bors
added a commit
that referenced
this pull request
May 20, 2017
Revert "Reenable opt-level 3" This reverts commit 30383b2, from #41967. We believe that this is causing the failures when compiling rustc on 64 bit (which are probably segfaults). cc @ishitatsuyuki
bors
added a commit
that referenced
this pull request
Jul 11, 2018
Set opt-level = 3 the third time. This PR reverts #51165 (set -O2 to fix #50867), which reverted #50329 (set -O3), which was second attempt of #48204 (set -O3, closed due to Windows segfault that is fixed now), which reverted #42123 (set -O2 to fix spurious Windows segfaults), which reverted #41967 (set -O3). Last time we've found that setting -O3 regressed the wall time of NLL (#50329 (comment)), so we may need another perf run to confirm. I'd like to check this *after* the LLVM 7 upgrade #51966 has been merged, so marking this as <kbd>S-blocked</kbd> for now.
bors
added a commit
that referenced
this pull request
Jul 14, 2018
Set opt-level = 3 the third time. This PR reverts #51165 (set -O2 for fixing #50867), which reverted #50329 (set -O3), which was second attempt of #48204 (set -O3, closed due to Windows segfault that is fixed now), which reverted #42123 (set -O2 to fix spurious Windows segfaults), which reverted #41967 (set -O3). Since we have found the root cause of #50867, this optimization could be tried again. Last time we've found that setting -O3 regressed the wall time of NLL (#50329 (comment)), so we may need another perf run to confirm. I'd like to check this *after* the LLVM 7 upgrade #51966 has been merged, so marking this as <kbd>S-blocked</kbd> for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment is quite old, let's see what would happen with current MSVC.
Since there's no AppVeyor test for PR, the best way is to try if it get through homu. I don't recommend doing this in roll-up.