Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow ._ in float literal. #41946

Merged
merged 1 commit into from
May 14, 2017

Conversation

qnighy
Copy link
Contributor

@qnighy qnighy commented May 12, 2017

This patch makes lexer stop parsing number literals before ._, as well as before .a. Underscore itself is still allowed like in 4_000_000.000_000_.

Fixes a half part of #41723. The other is ""_.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster
Copy link
Member

Thanks for the pull request! We'll get @pnkfelix or another team member to review this shortly!

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2017
@petrochenkov
Copy link
Contributor

@bors r+ rollup
Thanks!

@bors
Copy link
Contributor

bors commented May 13, 2017

📌 Commit 7b535e1 has been approved by petrochenkov

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 13, 2017
…loat, r=petrochenkov

Disallow ._ in float literal.

This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`.

Fixes a half part of rust-lang#41723. The other is `""_`.
bors added a commit that referenced this pull request May 13, 2017
Rollup of 5 pull requests

- Successful merges: #41826, #41919, #41946, #41967, #41969
- Failed merges: #41939
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 13, 2017
…loat, r=petrochenkov

Disallow ._ in float literal.

This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`.

Fixes a half part of rust-lang#41723. The other is `""_`.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 14, 2017
…loat, r=petrochenkov

Disallow ._ in float literal.

This patch makes lexer stop parsing number literals before `._`, as well as before `.a`. Underscore itself is still allowed like in `4_000_000.000_000_`.

Fixes a half part of rust-lang#41723. The other is `""_`.
bors added a commit that referenced this pull request May 14, 2017
Rollup of 7 pull requests

- Successful merges: #41612, #41826, #41939, #41946, #41950, #41975, #41979
- Failed merges:
@bors bors merged commit 7b535e1 into rust-lang:master May 14, 2017
@qnighy qnighy deleted the disallow-dot-underscore-in-float branch June 7, 2017 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants