Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regression test for ICE #33287 #41550

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Add a regression test for ICE #33287 #41550

merged 1 commit into from
Apr 27, 2017

Conversation

wesleywiser
Copy link
Member

Fixes #33287

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank
Copy link
Contributor

@wesleywiser this test is going to fail. You should move it to src/test/ui and create a .stderr file that checks the error output.

@wesleywiser
Copy link
Member Author

@estebank Perhaps I'm missing something obvious here, but why would this fail? It passed locally on my computer as well...

@estebank
Copy link
Contributor

@wesleywiser my mistake, you're absolutely right.

@bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2017

📌 Commit 9f96d0a has been approved by estebank

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41550 - wesleywiser:fix_33287, r=estebank
60b3247 
Add a regression test for ICE rust-lang#33287

Fixes rust-lang#33287
@frewsxcv frewsxcv mentioned this pull request Apr 26, 2017
Closed
@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 26, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41550 - wesleywiser:fix_33287, r=estebank
fcb8910 
Add a regression test for ICE rust-lang#33287

Fixes rust-lang#33287
@frewsxcv frewsxcv mentioned this pull request Apr 26, 2017
Closed
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of #41558 - frewsxcv:rollup, r=frewsxcv
30081ed 
Rollup of 7 pull requests

- Successful merges: #41370, #41447, #41456, #41493, #41499, #41501, #41550
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
Rollup merge of rust-lang#41550 - wesleywiser:fix_33287, r=estebank
c2bd3d3 
Add a regression test for ICE rust-lang#33287

Fixes rust-lang#33287
@arielb1 arielb1 mentioned this pull request Apr 26, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
Rollup merge of rust-lang#41550 - wesleywiser:fix_33287, r=estebank
f69c777 
Add a regression test for ICE rust-lang#33287

Fixes rust-lang#33287
@arielb1 arielb1 mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 27, 2017
@bors
Auto merge of #41567 - arielb1:rollup, r=arielb1
6e0c5af 
Rollup of 9 pull requests

- Successful merges: #41370, #41456, #41493, #41499, #41501, #41524, #41546, #41550, #41552
- Failed merges:
@bors bors merged commit 9f96d0a into rust-lang:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wesleywiser @rust-highfive @estebank @bors @nikomatsakis @aidanhs