Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bootstrap support for android #41370

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Add bootstrap support for android #41370

merged 1 commit into from
Apr 27, 2017

Conversation

malbarbo
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs
Copy link
Member

aidanhs commented Apr 19, 2017

Thanks for the PR @malbarbo! We'll make sure @brson or another reviewer gets to your PR soon.

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2017
@parched
Copy link
Contributor

parched commented Apr 20, 2017

What about aarch64?

@malbarbo
Copy link
Contributor Author

@parched This should work for all rust supported android archs.

@parched
Copy link
Contributor

parched commented Apr 20, 2017

Ah yes sorry, I see that now.

@Mark-Simulacrum
Copy link
Member

Thanks for the PR! We'll make sure that @brson or someone else reviews your PR soon.

cc @alexcrichton, perhaps you could take a look at this?

Note: Did not ping @brson on IRC due to them not being present.

@alexcrichton
Copy link
Member

@bors: r+

Thanks @malbarbo!

@bors
Copy link
Contributor

bors commented Apr 24, 2017

📌 Commit a42c025 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 24, 2017
@frewsxcv
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
2d2056e 
…richton

Add bootstrap support for android
@frewsxcv frewsxcv mentioned this pull request Apr 24, 2017
Closed
bors added a commit that referenced this pull request Apr 24, 2017
@bors
Auto merge of #41503 - frewsxcv:rollup, r=frewsxcv
38c99d2 
Rollup of 3 pull requests

- Successful merges: #40434, #41370, #41500
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 24, 2017
@frewsxcv
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
9fb3885 
…richton

Add bootstrap support for android
@frewsxcv frewsxcv mentioned this pull request Apr 24, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 24, 2017
@frewsxcv
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
b596b84 
…richton

Add bootstrap support for android
@frewsxcv frewsxcv mentioned this pull request Apr 24, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 25, 2017
@frewsxcv
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
429f8ff 
…richton

Add bootstrap support for android
@frewsxcv frewsxcv mentioned this pull request Apr 25, 2017
Closed
@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
3a5d623 
…richton

Add bootstrap support for android
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 25, 2017
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
81e1281 
…richton

Add bootstrap support for android
@arielb1 arielb1 mentioned this pull request Apr 25, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
1c04ff7 
…richton

Add bootstrap support for android
@frewsxcv frewsxcv mentioned this pull request Apr 26, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 26, 2017
@frewsxcv
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
e0e9a80 
…richton

Add bootstrap support for android
@frewsxcv frewsxcv mentioned this pull request Apr 26, 2017
Closed
bors added a commit that referenced this pull request Apr 26, 2017
@bors
Auto merge of #41558 - frewsxcv:rollup, r=frewsxcv
30081ed 
Rollup of 7 pull requests

- Successful merges: #41370, #41447, #41456, #41493, #41499, #41501, #41550
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
e1a3e66 
…richton

Add bootstrap support for android
@arielb1 arielb1 mentioned this pull request Apr 26, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 26, 2017
Rollup merge of rust-lang#41370 - malbarbo:android-bootstrap, r=alexc…
a3dde0b 
…richton

Add bootstrap support for android
@arielb1 arielb1 mentioned this pull request Apr 26, 2017
Merged
bors added a commit that referenced this pull request Apr 27, 2017
@bors
Auto merge of #41567 - arielb1:rollup, r=arielb1
6e0c5af 
Rollup of 9 pull requests

- Successful merges: #41370, #41456, #41493, #41499, #41501, #41524, #41546, #41550, #41552
- Failed merges:
@bors bors merged commit a42c025 into rust-lang:master Apr 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@malbarbo @rust-highfive @aidanhs @parched @Mark-Simulacrum @alexcrichton @bors @brson @arielb1