Rollup of 8 pull requests #41237
Merged
Rollup of 8 pull requests #41237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
frewsxcv
commented
Apr 11, 2017
frewsxcv
commented
- Successful merges: Implement optimization fuel and re-enable struct field reordering #40377, Implement Manually Drop #40559, Fix block code headers parsing #41173, Convert HashMap to BTree in build-manifest #41202, Fixes incorrect formatting in array's documentation. #41204, Make sccache a bit quieter #41209, Clarify Iterator::position doc #41216, Use correct vault URL in CentOS images #41231
- Failed merges:
less intrinsics = better life
…uct field reordering.
…hanges based on 32-bit or 64-bit architecture.
…uct field reordering.
Those did not take tuple reordering into account, causing majority of the compiler test suite to fail.
Extend the example a little bit to show behaviour better.
Implement optimization fuel and re-enable struct field reordering See [this discussion](https://internals.rust-lang.org/t/rolling-out-or-unrolling-struct-field-reorderings/4485) for background. This pull request adds two new compilation options: `-Z print-fuel=crate` prints the optimization fuel used by a crate and `-Z fuel=crate=n` sets the optimization fuel for a crate. It also turns field reordering back on. There is no way to test this feature without something consuming fuel. We can roll this back if we want, but then the optimization fuel bits will be dead code. The one notable absence from this PR is a test case. I'm not sure how to do one that's worth having. The only thing I can think of to test is `-Z fuel=foo=0`. The problem with other tests is that either (1) they're so big that future optimizations will apply, thus breaking them or (2) we don't know which order the optimizations will be applied in, so we can't guess the message that will be printed. If someone has a useful proposal for a good test, I certainly want to add one.
Implement Manually Drop As the RFC has been from approx a week in FCP without any major comments, I’m taking the opportunity to submit the PR early.
…ck-parsing, r=steveklabnik Fix block code headers parsing Fixes rust-lang#41167. r? @rust-lang/docs
Convert HashMap to BTree in build-manifest This is just for my peace of mind since it's important the output of this program be deterministic.
Fixes incorrect formatting in array's documentation. Changes - [`Clone`][clone] (only if `T: [Copy][copy]`) to - [`Clone`][clone] (only if `T: `[`Copy`](copy)) r? @steveklabnik
…richton Make sccache a bit quieter ...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)). r? @frewsxcv
Clarify Iterator::position doc Extend the example a little bit to show behaviour better. r? @steveklabnik
Use correct vault URL in CentOS images r? @frewsxcv
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit 72538de has been approved by |
bors
added a commit
that referenced
this pull request
Apr 12, 2017
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.