Make sccache a bit quieter #41209
Merged
Make sccache a bit quieter #41209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(per the IRC ping). As a data point, if a build has no sccache errors at all then the output of sccache.log goes from >10000 lines to about 3, plus we'll still get fatal errors. |
|
@bors: r+ Looks grea, thanks! |
|
📌 Commit f297767 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 11, 2017
…richton Make sccache a bit quieter ...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)). r? @frewsxcv
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 11, 2017
…richton Make sccache a bit quieter ...and remove the single mention of `SCCACHE_LOG_LEVEL` that would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (because [`RUST_LOG` takes priority](https://github.com/mozilla/sccache/blob/ec10cdb2ddeb3dde9891bea1fa095e504a60a28a/src/main.rs#L124-L128)). r? @frewsxcv
bors
added a commit
that referenced
this pull request
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove the single mention of
SCCACHE_LOG_LEVELthat would only take effect on Docker (i.e. Linux) builds since it had no effect anyway (becauseRUST_LOGtakes priority).r? @frewsxcv