Fix some typos in Nomicon #38994
Fix some typos in Nomicon #38994
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -11,7 +11,7 @@ lifetime can be regarded as `'static`. | |||
|
|
|||
| Almost no reference is `'static`, so this is probably wrong. `transmute` and | |||
| `transmute_copy` are the two other primary offenders. One should endeavor to | |||
| bound an unbounded lifetime as quick as possible, especially across function | |||
| bind an unbounded lifetime as quickly as possible, especially across function | |||
There was a problem hiding this comment.
I think bound is correct here. cf. "If an output lifetime is elided, then it must be bounded by an input lifetime." below.
|
Thanks, my fault, apparently I misread it three times >_< I acknowledge that "squashing it in the end" is usually preferred, according to |
|
Apparently this didn't trigger a new review request. Anyway: @sanxiyn: is this good? |
|
@bors r+ rollup |
|
📌 Commit 09df83b has been approved by |
Fix some typos in Nomicon I waited a bit before creating this PR in case I find more typos – I didn't. I've read `CONTRIBUTING.md` but didn't `make check`, and `make doc` takes incredibly long. (Among other things, `make doc` builds llvm from scratch. Not sure if that's intentional.)
I waited a bit before creating this PR in case I find more typos – I didn't.
I've read
CONTRIBUTING.mdbut didn'tmake check, andmake doctakes incredibly long. (Among other things,make docbuilds llvm from scratch. Not sure if that's intentional.)