Add missing links and examples for path modules and structs #38946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Thanks! @bors r+ rollup |
|
📌 Commit 8c40a0a has been approved by |
sanxiyn
suggested changes
Jan 10, 2017
| //! This module provides two types, `PathBuf` and `Path` (akin to `String` and | ||
| //! `str`), for working with paths abstractly. These types are thin wrappers | ||
| //! around `OsString` and `OsStr` respectively, meaning that they work directly | ||
| //! This module provides two types, [`PathBuf`] and [`Path`] (akin to [`String`] and |
There was a problem hiding this comment.
[Path] (akin to...) seems to be interpreted as a Markdown link, causing Travis failure in linkcheck.
|
@bors r- |
GuillaumeGomez
force-pushed
the
path_doc
branch
from
8c40a0a
to
0938b28
Compare
|
Updated. |
frewsxcv
suggested changes
Jan 10, 2017
| /// # Examples | ||
| /// | ||
| /// ```no_run | ||
| /// use std::path::{Path, PathBuf}; |
| /// # Examples | ||
| /// | ||
| /// ```no_run | ||
| /// use std::path::{Path, PathBuf}; |
There was a problem hiding this comment.
(certainly github bug actually)
GuillaumeGomez
force-pushed
the
path_doc
branch
from
0938b28
to
8ab66bf
Compare
|
Updated. |
GuillaumeGomez
force-pushed
the
path_doc
branch
from
8ab66bf
to
44ab7f1
Compare
frewsxcv
reviewed
Jan 11, 2017
| /// use std::path::Path; | ||
| /// | ||
| /// let path = Path::new("/foo/test/../test/bar.rs"); | ||
| /// assert_eq!(path.canonicalize().unwrap(), PathBuf::from("/foo/test/bar.rs")); |
There was a problem hiding this comment.
Oh damn, we'll never end it haha.
GuillaumeGomez
force-pushed
the
path_doc
branch
from
44ab7f1
to
28d1ac3
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit 28d1ac3 has been approved by |
sanxiyn
approved these changes
Jan 12, 2017
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 13, 2017
Add missing links and examples for path modules and structs r? @frewsxcv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @frewsxcv