Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #34541

Merged
merged 8 commits into from
Jul 1, 2016
Merged

Rollup of 5 pull requests #34541

merged 8 commits into from
Jul 1, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Jun 29, 2016 •
edited
Loading

ollie27 and others added 5 commits June 5, 2016 23:50
@ollie27
rustdoc: Remove Derived Implementations title
cc18104 
As far as I know whether a trait was derived or not does not change the
public API so there is no need to include this information in the docs.

This title currently just adds an extra divide in the list of trait
implementations which I don't think needs to be there.
Added Default trait for Cow
703d7b5
@CensoredUsername
Support CMake installations in paths containing spaces
37f0f67
@jseyfried
Rollup merge of rust-lang#34105 - ollie27:rustdoc_derived, r=alexcric…
2fda7d4 
…hton

rustdoc: Remove Derived Implementations title

As far as I know whether a trait was derived or not does not change the
public API so there is no need to include this information in the docs.

This title currently just adds an extra divide in the list of trait
implementations which I don't think needs to be there.
@jseyfried
Rollup merge of rust-lang#34305 - Aaronepower:master, r=alexcrichton
a77a179 
Added Default trait for Cow.

Adds a default implementation for Cow. Which is the Owned's default.
@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@jseyfried
Copy link
Contributor Author

@bors force r+

@bors
Copy link
Contributor

bors commented Jun 29, 2016

📌 Commit b4f7937 has been approved by jseyfried

@jseyfried
Copy link
Contributor Author

@bors force p=2

@bors
Copy link
Contributor

bors commented Jun 29, 2016

⌛ Testing commit b4f7937 with merge 3028db8...

@bors
Copy link
Contributor

bors commented Jun 29, 2016

⌛ Testing commit b4f7937 with merge 74bce92...

@bors
Copy link
Contributor

bors commented Jun 29, 2016

💔 Test failed - auto-linux-64-x-android-t

@jseyfried
Copy link
Contributor Author

@bors retry force clean

@bors
Copy link
Contributor

bors commented Jun 29, 2016

⌛ Testing commit b4f7937 with merge 12da950...

@jseyfried
Copy link
Contributor Author

cc @alexcrichton -- android timed out

@bors
Copy link
Contributor

bors commented Jun 29, 2016

💔 Test failed - auto-linux-64-x-android-t

@jseyfried
Copy link
Contributor Author

@bors retry

@bors
Copy link
Contributor

bors commented Jun 29, 2016

⚡ Previous build results for auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

@bors
Copy link
Contributor

bors commented Jun 29, 2016

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
Copy link
Member

Yeah looks like the android builder is having a lot of trouble right now, I'm gonna try to watch it closely to see if I can diagnose what's going on. I don't think it's related to changes in this PR, though.

@bors: retry

@bors
Copy link
Contributor

bors commented Jun 29, 2016

💣 Failed to start rebuilding: 301 Moved Permanently

@bors
Copy link
Contributor

bors commented Jun 29, 2016

⌛ Testing commit b4f7937 with merge 36309e1...

@jseyfried
Copy link
Contributor Author

@alexcrichton thanks, yeah android was failing the same way on several unrelated PRs.

@bors
Copy link
Contributor

bors commented Jun 29, 2016

💔 Test failed - auto-linux-64-x-android-t

@jseyfried
Rollup merge of rust-lang#34512 - CensoredUsername:configure-fixes, r…
bd7a363 
…=alexcrichton

Support CMake installations in paths containing spaces

This solves rust-lang#34490
@jseyfried
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2016

📌 Commit e59adb9 has been approved by jseyfried

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⌛ Testing commit e59adb9 with merge 50f1175...

@bors
Copy link
Contributor

bors commented Jun 30, 2016

💔 Test failed - auto-win-gnu-64-opt

@jseyfried
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Jun 30, 2016

📌 Commit a8751e0 has been approved by jseyfried

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⌛ Testing commit a8751e0 with merge 85c31af...

bors added a commit that referenced this pull request Jun 30, 2016
@bors
Auto merge of #34541 - jseyfried:rollup, r=jseyfried
85c31af 
Rollup of 5 pull requests

 - Successful merges: #34105, #34305, #34512, ~~#34531,~~ #34547
@bors
Copy link
Contributor

bors commented Jun 30, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@jseyfried
Copy link
Contributor Author

@bors retry

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-cross-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-musl-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

@bors
Copy link
Contributor

bors commented Jun 30, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Jun 30, 2016 at 7:48 AM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1610

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34541 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95IpetbqwFnlKkwGiQRos4JF9JfpNks5qQ9clgaJpZM4JArNY
.

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt-rustbuild, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-x-android-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild...

@bors
Copy link
Contributor

bors commented Jun 30, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@arielb1
Copy link
Contributor

arielb1 commented Jun 30, 2016 

---- Rust_Compiler_Error_Index_537 stdout ----
    <anon>:1:1: 1:15 error: export_name attribute has invalid format
<anon>:1 #[export_name]
         ^~~~~~~~~~~~~~
<anon>:1:1: 1:15 help: use #[export_name="*"]
thread 'Rust_Compiler_Error_Index_537' panicked at 'Some expected error codes were not found: ["E0533"]', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustdoc/test.rs:298

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Jun 30, 2016 at 2:38 PM, arielb1 notifications@github.com wrote:

---- Rust_Compiler_Error_Index_537 stdout ----
:1:1: 1:15 error: export_name attribute has invalid format
:1 #[export_name]
^~~~~~~~~~~~~~
:1:1: 1:15 help: use #[export_name="*"]
thread 'Rust_Compiler_Error_Index_537' panicked at 'Some expected error codes were not found: ["E0533"]', /Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt-rustbuild/build/src/librustdoc/test.rs:298

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#34541 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95H4i8SwzayFFRlsrGroPPGUNj6wZks5qRDdAgaJpZM4JArNY
.

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir...

@bors
Copy link
Contributor

bors commented Jun 30, 2016

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented Jul 1, 2016

⚡ Previous build results for auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-cross-ios-opt, auto-win-gnu-32-opt-rustbuild, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt-rustbuild are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-win-gnu-32-opt, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir...

@bors
Copy link
Contributor

bors commented Jul 1, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors mentioned this pull request Jul 1, 2016
Merged
@bors bors merged commit a8751e0 into rust-lang:master Jul 1, 2016
@bors bors mentioned this pull request Jul 1, 2016
Closed
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aatch Aatch

Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jseyfried @rust-highfive @bors @alexcrichton @arielb1 @Aatch @Centril @ollie27 @CensoredUsername @sanxiyn