Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CMake installations in paths containing spaces #34512

Merged
merged 1 commit into from
Jul 1, 2016

Conversation

CensoredUsername
Copy link
Contributor

This solves #34490

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ 37f0f67

Thanks!

jseyfried added a commit to jseyfried/rust that referenced this pull request Jun 30, 2016
…=alexcrichton

Support CMake installations in paths containing spaces

This solves rust-lang#34490
bors added a commit that referenced this pull request Jun 30, 2016
Rollup of 5 pull requests

 - Successful merges: #34105, #34305, #34512, ~~#34531,~~ #34547
@bors bors merged commit 37f0f67 into rust-lang:master Jul 1, 2016
@CensoredUsername CensoredUsername deleted the configure-fixes branch July 1, 2016 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants