-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: simplify wording #34145
docs: simplify wording #34145
Conversation
Hmmm. We don't usually use these words these ways, though I do agree that the original sentence is awkward. What about something like
? |
Do you mean that something's wrong with the English, or that something's wrong with the Rust terminology (static type)? In the latter case we might want to change the module level docs as well because they mention "static type". I've updated the PR anyway. Wow, I think I see it now. "dynamic typing of static types" surely can cause confusion if you are not familiar with lifetimes. Should I change the module level docs to something like
|
The latter, we don't call things "static types". It's entirely possible that the module docs are bad; I haven't looked at them at all, so they've been whatever someone has felt like writing from a long time back, possibly before we even had unified terminology.
This is where terms get hard :) Strictly speaking, a type doesn't have a lifetime, a type might be parameterized over a lifetime, though... My first reaction is something similar: "of many types through runtime reflection." and then mention the exception after the summary line. |
(that said, I'm also happy to merge this without updating the module docs, whichever you want!) |
Ok, lets merge this as is. Looks like it's better to revise the whole docs for
How would you say |
@bors: r+ rollup I agree 😄
Usually "bound by the |
📌 Commit 7abdbd4 has been approved by |
docs: simplify wording It took me more then a moment to decipher "with no non-`'static`" thing :) "`'static` type" should say the same thing more clearly. r? @steveklabnik
docs: simplify wording It took me more then a moment to decipher "with no non-`'static`" thing :) "`'static` type" should say the same thing more clearly. r? @steveklabnik
docs: simplify wording It took me more then a moment to decipher "with no non-`'static`" thing :) "`'static` type" should say the same thing more clearly. r? @steveklabnik
It took me more then a moment to decipher "with no non-
'static
" thing :)"
'static
type" should say the same thing more clearly.r? @steveklabnik