-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test case for borrowk ICE #25579 #34136
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
} | ||
|
||
fn causes_ice(mut l: &mut Sexpression) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style guide says the {
needs to be on the previous line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I don't agree with this in particular -- we follow various conventions in the compiler :) -- but also this is a test case, where the conventions are looser still, particularly since this is a regression test.
That said, I don't see any harm in reformatting either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reformatted the code above, I think it makes sense to have it indented 4 spaces and the brace on the same line as the if statment, consistent with the rest of the file anyway.
I need to resolve the failed build then hopefully this should be good to go.
5d8bc1e
to
0379493
Compare
@bors r+ rollup |
📌 Commit 4c5f3a6 has been approved by |
…=nikomatsakis Test case for borrowk ICE rust-lang#25579 r? @nikomatsakis Fixes rust-lang#25579
…=nikomatsakis Test case for borrowk ICE rust-lang#25579 r? @nikomatsakis Fixes rust-lang#25579
…=nikomatsakis Test case for borrowk ICE rust-lang#25579 r? @nikomatsakis Fixes rust-lang#25579
r? @nikomatsakis
Fixes #25579