Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IPV6_V6ONLY functionality #33124

Merged
merged 1 commit into from
Apr 24, 2016
Merged

Remove IPV6_V6ONLY functionality #33124

merged 1 commit into from
Apr 24, 2016

Conversation

sfackler
Copy link
Member

These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes #33052

[breaking-change]

r? @alexcrichton

Will also need a backport to the beta.

@sfackler
Remove IPV6_V6ONLY functionality
c6480e8 
These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes rust-lang#33052

[breaking-change]
@sfackler sfackler added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 21, 2016
@alexcrichton
Copy link
Member

cc @rust-lang/libs, thinking of merging this soon!

@alexcrichton
Copy link
Member

I'll also note that these methods aren't completely useless. It's possible to create a socket manually, wrap it up in TcpStream, and then later manually connect it. In that sense it can theoretically be possible for these to be useful, but I think that case would be so vanishingly rare it's not worth it.

@BurntSushi
Copy link
Member

BurntSushi commented Apr 21, 2016 •
edited
Loading

@alexcrichton Are there any cases where one would want or need to do that? (Otherwise, this sounds fine to me!)

@alexcrichton
Copy link
Member

Probably not, just pointing out it's not literally useless, just morally so :)

@aturon
Copy link
Member

aturon commented Apr 21, 2016

This is fine by me in principle.

If we're at all concern about the breakage, we could consider landing a deprecation warning (so that people get a heads up on nightly) and then landing the removal a couple weeks later.

@sfackler
Copy link
Member Author

I'd normally go that route, but since in all reasonable uses these methods will never work, I'm not expecting anyone to be using them.

@aturon
Copy link
Member

aturon commented Apr 21, 2016

I'd normally go that route, but since in all reasonable uses these methods will never work, I'm not expecting anyone to be using them.

Yep. I’m fine either way.

@alexcrichton
Copy link
Member

@bors: r+ c6480e8

@bors
Copy link
Contributor

bors commented Apr 23, 2016

⌛ Testing commit c6480e8 with merge 23ccadd...

bors added a commit that referenced this pull request Apr 23, 2016
@bors
Auto merge of #33124 - sfackler:kill-ipv6-only, r=alexcrichton
23ccadd 
Remove IPV6_V6ONLY functionality

These settings can only be adjusted before bind time, which doesn't make
sense in the current set of functionality. These methods are stable, but
haven't hit a stable release yet.

Closes #33052

[breaking-change]

r? @alexcrichton

Will also need a backport to the beta.
@bors
Copy link
Contributor

bors commented Apr 24, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit c6480e8 into rust-lang:master Apr 24, 2016
@sfackler sfackler deleted the kill-ipv6-only branch April 24, 2016 00:12
@alexcrichton alexcrichton mentioned this pull request Apr 29, 2016
Merged
@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 29, 2016
@alexcrichton
Copy link
Member

Accepted for backport in #33263 (comment)

@sfackler sfackler mentioned this pull request Dec 11, 2016
Merged
sfackler added a commit to sfackler/rust that referenced this pull request Jan 6, 2017
@sfackler
Deprecate TcpListener::set_only_v6
eb5e9ab 
This was supposed to have been removed in rust-lang#33124 but snuck through :(
bors added a commit that referenced this pull request Jan 6, 2017
@bors
Auto merge of #38304 - sfackler:no-ipv6only, r=alexcrichton
a28701a 
Deprecate TcpListener::set_only_v6

This was supposed to have been removed in #33124 but snuck through :(

Should the docs be removed?

I left the accessor undeprecated since it should actually work, though that method doesn't exist on other networking types.

r? @alexcrichton
cc @rust-lang/libs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfackler @alexcrichton @BurntSushi @aturon @bors