-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net::{TcpStream,TcpListener}::set_only_v6
are useless
#33052
Labels
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
Oops, yeah, I'd say we should probably back these out of the beta. I'll raise it for discussion during libs triage. @rust-lang/libs. |
sfackler
added a commit
to sfackler/rust
that referenced
this issue
Apr 21, 2016
These settings can only be adjusted before bind time, which doesn't make sense in the current set of functionality. These methods are stable, but haven't hit a stable release yet. Closes rust-lang#33052 [breaking-change]
bors
added a commit
that referenced
this issue
Apr 23, 2016
Remove IPV6_V6ONLY functionality These settings can only be adjusted before bind time, which doesn't make sense in the current set of functionality. These methods are stable, but haven't hit a stable release yet. Closes #33052 [breaking-change] r? @alexcrichton Will also need a backport to the beta.
sfackler
added a commit
to sfackler/rust
that referenced
this issue
Apr 28, 2016
These settings can only be adjusted before bind time, which doesn't make sense in the current set of functionality. These methods are stable, but haven't hit a stable release yet. Closes rust-lang#33052 [breaking-change] (cherry picked from commit c6480e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AFAIUI,
net::TcpListener::set_only_v6
has to be called beforebind
ing a socket. However, with the current API this is not possible.For
TcpStream
I'm not sure if this option is meaningful at all. And if it is, it surely has to be set beforeconnect
ing.I know the FCP for those is over, but they should still be removed IMO.
The text was updated successfully, but these errors were encountered: